1345034 - Label runnables in dom/media/WMFMediaDataDecoder.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1345034 - Label runnables in dom/media/WMFMediaDataDecoder.cpp;

Review commit: https://reviewboard.mozilla.org/r/117844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117844/

Comment 2

[Tzuhao Kuo [:kaku]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c38d71d7e5e5a98db60a2d55c495c43797462d4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=934f11c05918ed96219dc06ede99030a12975839

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8844354 [details]
Bug 1345034 - Label runnables in dom/media/WMFMediaDataDecoder.cpp;

https://reviewboard.mozilla.org/r/117844/#review119502

::: dom/media/platforms/wmf/WMFMediaDataDecoder.cpp:67
(Diff revision 1)
>    }
>  
> -  nsCOMPtr<nsIRunnable> runnable = NS_NewRunnableFunction(
> +  SystemGroup::Dispatch("WMFMediaDataDecoder::SendTelemetry",
> +                        TaskCategory::Other,
> +                        NS_NewRunnableFunction(
> -    [sample] {
> +                            [sample] {

2-space indentation or store the return value of NS_NewRunnableFunction() in a temp so it is easier to align the code.

Please also open new bugs to label runnables involing Telemetry.

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8844354 [details]
Bug 1345034 - Label runnables in dom/media/WMFMediaDataDecoder.cpp;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117844/diff/1-2/

Comment 5

[Tzuhao Kuo [:kaku]]

Try again:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=889f204c8d00df6a164d619634484edbe6947ca8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f66973044676bba5a2329abac5bb1a829d10321

Comment 6

[Tzuhao Kuo [:kaku]]

Try looks good and thank for the review!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/079e82b5210e
Label runnables in dom/media/WMFMediaDataDecoder.cpp; r=jwwang

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/079e82b5210e