Add webrender support for nsDisplayImage

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: ethlin, Assigned: ethlin)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 months ago
For the first run conversion, we should also support it. And I think it's just like 'ForceActiveLayers'.
(Assignee)

Comment 1

8 months ago
Created attachment 8844383 [details] [diff] [review]
add wr support for nsDisplayImage

We should just reuse WebRenderImageLayer, so I set the layer as a active layer for LAYERS_WR.
Attachment #8844383 - Flags: review?(matt.woodrow)
(Assignee)

Comment 2

8 months ago
Created attachment 8844819 [details] [diff] [review]
add wr support for nsDisplayImage

Per [1], there are many reftests failures if we always create WRImageLayer. So I add a pref for it.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0a36e5a39eb6d6c3712dcc4dabee100de01a2e5&selectedJob=82118849
Attachment #8844383 - Attachment is obsolete: true
Attachment #8844383 - Flags: review?(matt.woodrow)
Attachment #8844819 - Flags: review?(matt.woodrow)
Attachment #8844819 - Flags: review?(matt.woodrow) → review+

Comment 3

8 months ago
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a0760865f8b
Add webrender support for nsDisplayImage. r=mattwoodrow

Comment 4

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3a0760865f8b
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(In reply to Ethan Lin[:ethlin] from comment #2)
> Created attachment 8844819 [details] [diff] [review]
> add wr support for nsDisplayImage
> 
> Per [1], there are many reftests failures if we always create WRImageLayer.
> So I add a pref for it.

... except you landed it without the pref, causing all the QR tests on mozilla-central to fail :(

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=da0ea1c722078f30c6f390627d3c680d3556a7a6&filter-searchStr=quantum
Depends on: 1345833
Backed out: https://hg.mozilla.org/mozilla-central/rev/2e690f96d0be75a7c7d5d0cbbc26997851473a16
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

8 months ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)
> (In reply to Ethan Lin[:ethlin] from comment #2)
> > Created attachment 8844819 [details] [diff] [review]
> > add wr support for nsDisplayImage
> > 
> > Per [1], there are many reftests failures if we always create WRImageLayer.
> > So I add a pref for it.
> 
> ... except you landed it without the pref, causing all the QR tests on
> mozilla-central to fail :(
> 
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> central&revision=da0ea1c722078f30c6f390627d3c680d3556a7a6&filter-
> searchStr=quantum

Oh...I seems to push the original patch. I'll fix it.

Comment 8

8 months ago
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e0025254bee
Add webrender support for nsDisplayImage. r=mattwoodrow

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8e0025254bee
Status: REOPENED → RESOLVED
Last Resolved: 8 months ago8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.