1345053 - Add webrender support for nsDisplayImage

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

For the first run conversion, we should also support it. And I think it's just like 'ForceActiveLayers'.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: add wr support for nsDisplayImage

We should just reuse WebRenderImageLayer, so I set the layer as a active layer for LAYERS_WR.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: add wr support for nsDisplayImage

Per [1], there are many reftests failures if we always create WRImageLayer. So I add a pref for it.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0a36e5a39eb6d6c3712dcc4dabee100de01a2e5&selectedJob=82118849

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a0760865f8b
Add webrender support for nsDisplayImage. r=mattwoodrow

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a0760865f8b

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Ethan Lin[:ethlin] from comment #2)
> Created attachment 8844819 [details] [diff] [review]
> add wr support for nsDisplayImage
> 
> Per [1], there are many reftests failures if we always create WRImageLayer.
> So I add a pref for it.

... except you landed it without the pref, causing all the QR tests on mozilla-central to fail :(

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=da0ea1c722078f30c6f390627d3c680d3556a7a6&filter-searchStr=quantum

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Backed out: https://hg.mozilla.org/mozilla-central/rev/2e690f96d0be75a7c7d5d0cbbc26997851473a16

Comment 7

[Ethan Lin[:ethlin]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> (In reply to Ethan Lin[:ethlin] from comment #2)
> > Created attachment 8844819 [details] [diff] [review]
> > add wr support for nsDisplayImage
> > 
> > Per [1], there are many reftests failures if we always create WRImageLayer.
> > So I add a pref for it.
> 
> ... except you landed it without the pref, causing all the QR tests on
> mozilla-central to fail :(
> 
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> central&revision=da0ea1c722078f30c6f390627d3c680d3556a7a6&filter-
> searchStr=quantum

Oh...I seems to push the original patch. I'll fix it.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e0025254bee
Add webrender support for nsDisplayImage. r=mattwoodrow

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8e0025254bee