Closed
Bug 1345053
Opened 7 years ago
Closed 7 years ago
Add webrender support for nsDisplayImage
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.08 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
For the first run conversion, we should also support it. And I think it's just like 'ForceActiveLayers'.
|
Assignee | |
Comment 1•7 years ago
|
||
We should just reuse WebRenderImageLayer, so I set the layer as a active layer for LAYERS_WR.
Attachment #8844383 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Per [1], there are many reftests failures if we always create WRImageLayer. So I add a pref for it. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0a36e5a39eb6d6c3712dcc4dabee100de01a2e5&selectedJob=82118849
Attachment #8844383 -
Attachment is obsolete: true
Attachment #8844383 -
Flags: review?(matt.woodrow)
Attachment #8844819 -
Flags: review?(matt.woodrow)
|
||
Updated•7 years ago
|
Attachment #8844819 -
Flags: review?(matt.woodrow) → review+
Pushed by ethlin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3a0760865f8b Add webrender support for nsDisplayImage. r=mattwoodrow
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3a0760865f8b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Comment 5•7 years ago
|
||
(In reply to Ethan Lin[:ethlin] from comment #2) > Created attachment 8844819 [details] [diff] [review] > add wr support for nsDisplayImage > > Per [1], there are many reftests failures if we always create WRImageLayer. > So I add a pref for it. ... except you landed it without the pref, causing all the QR tests on mozilla-central to fail :( https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=da0ea1c722078f30c6f390627d3c680d3556a7a6&filter-searchStr=quantum
|
|
||
Comment 6•7 years ago
|
||
Backed out: https://hg.mozilla.org/mozilla-central/rev/2e690f96d0be75a7c7d5d0cbbc26997851473a16
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•7 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5) > (In reply to Ethan Lin[:ethlin] from comment #2) > > Created attachment 8844819 [details] [diff] [review] > > add wr support for nsDisplayImage > > > > Per [1], there are many reftests failures if we always create WRImageLayer. > > So I add a pref for it. > > ... except you landed it without the pref, causing all the QR tests on > mozilla-central to fail :( > > https://treeherder.mozilla.org/#/jobs?repo=mozilla- > central&revision=da0ea1c722078f30c6f390627d3c680d3556a7a6&filter- > searchStr=quantum Oh...I seems to push the original patch. I'll fix it.
Pushed by ethlin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e0025254bee Add webrender support for nsDisplayImage. r=mattwoodrow
|
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8e0025254bee
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•