Closed
Bug 1345202
Opened 7 years ago
Closed 7 years ago
Preemptively fix unified bustage in layout/svg
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(3 files)
Following up on bug 1300206 -- non-unified builds are busted in layout/svg again, with various build errors. Patches coming up to fix.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8844568 [details] Bug 1345202 part 1: Add missing mozilla:: namespace prefixes in layout/svg/*.h. https://reviewboard.mozilla.org/r/117946/#review119876
Attachment #8844568 -
Flags: review?(tlin) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8844569 [details] Bug 1345202 part 2: Add "using namespace mozilla::image" to all layout/svg/*.cpp files that use the DrawResult type. https://reviewboard.mozilla.org/r/117948/#review119874 ::: layout/svg/nsSVGMarkerFrame.cpp:17 (Diff revision 1) > #include "mozilla/dom/SVGMarkerElement.h" > #include "SVGGeometryElement.h" > #include "SVGGeometryFrame.h" > > using namespace mozilla::dom; > +using namespace mozilla::image; Nit: Add this line after "mozilla::gfx" to retain the alphabetic order, please.
Attachment #8844569 -
Flags: review?(tlin) → review+
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8844569 [details] Bug 1345202 part 2: Add "using namespace mozilla::image" to all layout/svg/*.cpp files that use the DrawResult type. https://reviewboard.mozilla.org/r/117948/#review119874 > Nit: Add this line after "mozilla::gfx" to retain the alphabetic order, please. Thanks! Fixed locally.
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8844570 [details] Bug 1345202 part 3: Add a few more required 'using' and #include statements in layout/svg. https://reviewboard.mozilla.org/r/117950/#review119882
Attachment #8844570 -
Flags: review?(tlin) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/214ed4e5d41f part 1: Add missing mozilla:: namespace prefixes in layout/svg/*.h. r=TYLin https://hg.mozilla.org/integration/autoland/rev/0fa0d070ca5c part 2: Add "using namespace mozilla::image" to all layout/svg/*.cpp files that use the DrawResult type. r=TYLin https://hg.mozilla.org/integration/autoland/rev/d2ccb122d517 part 3: Add a few more required 'using' and #include statements in layout/svg. r=TYLin
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/214ed4e5d41f https://hg.mozilla.org/mozilla-central/rev/0fa0d070ca5c https://hg.mozilla.org/mozilla-central/rev/d2ccb122d517
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•