1345202 - Preemptively fix unified bustage in layout/svg

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Daniel Holbert [:dholbert]]

Following up on bug 1300206 -- non-unified builds are busted in layout/svg
again, with various build errors.

Patches coming up to fix.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1345202 part 1: Add missing mozilla:: namespace prefixes in layout/svg/*.h.

These only build successfully (in unified mode) right now because they're lucky
enough to pick up a "using namespace mozilla;" declaration from a .cpp file
earlier in their unified compilation unit.

Review commit: https://reviewboard.mozilla.org/r/117946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117946/

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1345202 part 2: Add "using namespace mozilla::image" to all layout/svg/*.cpp files that use the DrawResult type.

(DrawResult is really mozilla::image::DrawResult.)

Review commit: https://reviewboard.mozilla.org/r/117948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117948/

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1345202 part 3: Add a few more required 'using' and #include statements in layout/svg.

Specifically:
 - SVGGeometryFrame.cpp has several uses the type SVGGeometryElement which is
   really mozilla::dom::SVGGeometryElement. So I'm adding a 'using' decl for
   the 'mozilla::dom' namespace (and I'm dropping a now-unnecessary explicit
   dom:: prefix from another type there).
 - SVGImageContext.cpp calls several functions on nsIFrame (PresContext() &
   StyleSVG() at least). So I'm adding an #include for nsIFrame.h.
 - nsSVGMarkerFrame.cpp uses the type SVGGeometryFrame, which is really
   mozilla::SVGGeometryFrame. So I'm adding a 'using' decl for
   the 'mozilla' namespace.

Review commit: https://reviewboard.mozilla.org/r/117950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117950/

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8844568 [details]
Bug 1345202 part 1: Add missing mozilla:: namespace prefixes in layout/svg/*.h.

https://reviewboard.mozilla.org/r/117946/#review119876

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8844569 [details]
Bug 1345202 part 2: Add "using namespace mozilla::image" to all layout/svg/*.cpp files that use the DrawResult type.

https://reviewboard.mozilla.org/r/117948/#review119874

::: layout/svg/nsSVGMarkerFrame.cpp:17
(Diff revision 1)
>  #include "mozilla/dom/SVGMarkerElement.h"
>  #include "SVGGeometryElement.h"
>  #include "SVGGeometryFrame.h"
>  
>  using namespace mozilla::dom;
> +using namespace mozilla::image;

Nit: Add this line after "mozilla::gfx" to retain the alphabetic order, please.

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8844569 [details]
Bug 1345202 part 2: Add "using namespace mozilla::image" to all layout/svg/*.cpp files that use the DrawResult type.

https://reviewboard.mozilla.org/r/117948/#review119874

> Nit: Add this line after "mozilla::gfx" to retain the alphabetic order, please.

Thanks! Fixed locally.

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8844570 [details]
Bug 1345202 part 3: Add a few more required 'using' and #include statements in layout/svg.

https://reviewboard.mozilla.org/r/117950/#review119882

Comment 8

[Daniel Holbert [:dholbert]]

Comment on attachment 8844568 [details]
Bug 1345202 part 1: Add missing mozilla:: namespace prefixes in layout/svg/*.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117946/diff/1-2/

Comment 9

[Daniel Holbert [:dholbert]]

Comment on attachment 8844569 [details]
Bug 1345202 part 2: Add "using namespace mozilla::image" to all layout/svg/*.cpp files that use the DrawResult type.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117948/diff/1-2/

Comment 10

[Daniel Holbert [:dholbert]]

Comment on attachment 8844570 [details]
Bug 1345202 part 3: Add a few more required 'using' and #include statements in layout/svg.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117950/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/214ed4e5d41f
part 1: Add missing mozilla:: namespace prefixes in layout/svg/*.h. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/0fa0d070ca5c
part 2: Add "using namespace mozilla::image" to all layout/svg/*.cpp files that use the DrawResult type. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/d2ccb122d517
part 3: Add a few more required 'using' and #include statements in layout/svg. r=TYLin

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/214ed4e5d41f
https://hg.mozilla.org/mozilla-central/rev/0fa0d070ca5c
https://hg.mozilla.org/mozilla-central/rev/d2ccb122d517