Closed Bug 1345324 Opened 3 years ago Closed 3 years ago
Label runnables for CDMProxy sub-classes
59 bytes, text/x-review-board-request
They are MediaDrmCDMProxy and GMPCDMProxy.
Assignee: nobody → jwwang
Priority: -- → P3
Comment on attachment 8844765 [details] Bug 1345324 - Label runnables for CDMProxy sub-classes. https://reviewboard.mozilla.org/r/118092/#review119940 Thanks for writing these patches. You could pass the event target to the CDMProxy constructor, so that each implementation doesn't need to remember to set CDMProxy::mMainThread to aMainThread in their Init method. That way you reduce the duplicated code that sets CDMProxy::mThread.
Attachment #8844765 - Flags: review?(cpearce) → review+
Comment on attachment 8844765 [details] Bug 1345324 - Label runnables for CDMProxy sub-classes. https://reviewboard.mozilla.org/r/118092/#review119940 Yes, I can do that in a new bug for I want to keep changes in control flow as minimized as possible in this bug. http://searchfox.org/mozilla-central/rev/d4adaabd6d2f88be0d0b151e022c06f6554909da/dom/media/eme/MediaKeys.cpp#376 To pass |top->GetExtantDoc()->EventTargetFor()| to the constructor of CDMProxy, you have to deal with exceptions like null |window| or null |top| first.
Thanks for the review!
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/74bd66f2490e Label runnables for CDMProxy sub-classes. r=cpearce
You need to log in before you can comment on or make changes to this bug.