Label runnables for CDMProxy sub-classes

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [QDL][TDC-MVP][MEDIA])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
They are MediaDrmCDMProxy and GMPCDMProxy.
(Assignee)

Updated

a year ago
Assignee: nobody → jwwang
Blocks: 1341539
Priority: -- → P3
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8844765 [details]
Bug 1345324 - Label runnables for CDMProxy sub-classes.

https://reviewboard.mozilla.org/r/118092/#review119940

Thanks for writing these patches.

You could pass the event target to the CDMProxy constructor, so that each implementation doesn't need to remember to set CDMProxy::mMainThread to aMainThread in their Init method. That way you reduce the duplicated code that sets CDMProxy::mThread.
Attachment #8844765 - Flags: review?(cpearce) → review+
(Assignee)

Comment 3

a year ago
mozreview-review-reply
Comment on attachment 8844765 [details]
Bug 1345324 - Label runnables for CDMProxy sub-classes.

https://reviewboard.mozilla.org/r/118092/#review119940

Yes, I can do that in a new bug for I want to keep changes in control flow as minimized as possible in this bug.

http://searchfox.org/mozilla-central/rev/d4adaabd6d2f88be0d0b151e022c06f6554909da/dom/media/eme/MediaKeys.cpp#376
To pass |top->GetExtantDoc()->EventTargetFor()| to the constructor of CDMProxy, you have to deal with exceptions like null |window| or null |top| first.
(Assignee)

Comment 4

a year ago
Thanks for the review!

Comment 5

a year ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74bd66f2490e
Label runnables for CDMProxy sub-classes. r=cpearce

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/74bd66f2490e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Updated

a year ago
Blocks: 1345753

Updated

a year ago
Whiteboard: [QDL][TDC-MVP][MEDIA]
You need to log in before you can comment on or make changes to this bug.