1345343 - Add a pref to turn off xml:base for style attribute

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+11]

The telemetry for xml:base doesn't look quite good... We want to try turning off xml:base for just style attribute and see if we can find any specific case this causes any issue.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

heycam brought to me that we may need to investigate base URI for presentation attributes as well. Some of SVG presentation attributes may be affected by that, and we want to drop it as well.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1345343 - Add a pref to turn off effect of xml:base on style attribute.

Review commit: https://reviewboard.mozilla.org/r/118918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118918/

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

bz, could you review this patch?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8845772 [details]
Bug 1345343 - Add a pref to turn off effect of xml:base on style attribute.

https://reviewboard.mozilla.org/r/118918/#review120864

r=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/349830b775ae
Add a pref to turn off effect of xml:base on style attribute. r=bz

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Thanks for reviewing.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/349830b775ae

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

Jet, this bug adds pref "layout.css.style-attr-with-xml-base.disabled" to disable xml:base for style attribute. Could you bring this to webcompat team and see if they can test with this pref turned on and see if anything is broken? Or do you think we can simply turn it on in aurora and nightly?

Comment 9

[Jet Villegas (inactive)]

(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #8)
> Jet, this bug adds pref "layout.css.style-attr-with-xml-base.disabled" to
> disable xml:base for style attribute. Could you bring this to webcompat team
> and see if they can test with this pref turned on and see if anything is
> broken? 

https://groups.google.com/forum/#!topic/mozilla.compatibility/z2syZhkI1-U

> Or do you think we can simply turn it on in aurora and nightly?

Let's see what the telemetry in bug 1344102 comes back with.

Comment 10

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Jet Villegas (:jet) from comment #9)
> > Or do you think we can simply turn it on in aurora and nightly?
> 
> Let's see what the telemetry in bug 1344102 comes back with.

It comes similar bad: https://mzl.la/2noihqI

But that's not about style attribute. It is only about styled element, which includes any usage on xul, html, and svg elements.