Closed Bug 1345343 Opened 3 years ago Closed 3 years ago

Add a pref to turn off xml:base for style attribute

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

The telemetry for xml:base doesn't look quite good... We want to try turning off xml:base for just style attribute and see if we can find any specific case this causes any issue.
heycam brought to me that we may need to investigate base URI for presentation attributes as well. Some of SVG presentation attributes may be affected by that, and we want to drop it as well.
bz, could you review this patch?
Flags: needinfo?(bzbarsky)
Comment on attachment 8845772 [details]
Bug 1345343 - Add a pref to turn off effect of xml:base on style attribute.

https://reviewboard.mozilla.org/r/118918/#review120864

r=me
Attachment #8845772 - Flags: review+
Assignee: nobody → xidorn+moz
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/349830b775ae
Add a pref to turn off effect of xml:base on style attribute. r=bz
Flags: needinfo?(bzbarsky)
Thanks for reviewing.
https://hg.mozilla.org/mozilla-central/rev/349830b775ae
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Jet, this bug adds pref "layout.css.style-attr-with-xml-base.disabled" to disable xml:base for style attribute. Could you bring this to webcompat team and see if they can test with this pref turned on and see if anything is broken? Or do you think we can simply turn it on in aurora and nightly?
Flags: needinfo?(bugs)
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #8)
> Jet, this bug adds pref "layout.css.style-attr-with-xml-base.disabled" to
> disable xml:base for style attribute. Could you bring this to webcompat team
> and see if they can test with this pref turned on and see if anything is
> broken? 

https://groups.google.com/forum/#!topic/mozilla.compatibility/z2syZhkI1-U

> Or do you think we can simply turn it on in aurora and nightly?

Let's see what the telemetry in bug 1344102 comes back with.
Flags: needinfo?(bugs)
(In reply to Jet Villegas (:jet) from comment #9)
> > Or do you think we can simply turn it on in aurora and nightly?
> 
> Let's see what the telemetry in bug 1344102 comes back with.

It comes similar bad: https://mzl.la/2noihqI

But that's not about style attribute. It is only about styled element, which includes any usage on xul, html, and svg elements.
Blocks: 1349024
Blocks: 1349059
You need to log in before you can comment on or make changes to this bug.