Add a pref to turn off xml:base for style attribute

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The telemetry for xml:base doesn't look quite good... We want to try turning off xml:base for just style attribute and see if we can find any specific case this causes any issue.
(Assignee)

Comment 1

a year ago
heycam brought to me that we may need to investigate base URI for presentation attributes as well. Some of SVG presentation attributes may be affected by that, and we want to drop it as well.
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
bz, could you review this patch?
Flags: needinfo?(bzbarsky)
Comment on attachment 8845772 [details]
Bug 1345343 - Add a pref to turn off effect of xml:base on style attribute.

https://reviewboard.mozilla.org/r/118918/#review120864

r=me
Attachment #8845772 - Flags: review+
(Assignee)

Updated

a year ago
Assignee: nobody → xidorn+moz

Comment 5

a year ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/349830b775ae
Add a pref to turn off effect of xml:base on style attribute. r=bz
Flags: needinfo?(bzbarsky)
(Assignee)

Comment 6

a year ago
Thanks for reviewing.

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/349830b775ae
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Comment 8

a year ago
Jet, this bug adds pref "layout.css.style-attr-with-xml-base.disabled" to disable xml:base for style attribute. Could you bring this to webcompat team and see if they can test with this pref turned on and see if anything is broken? Or do you think we can simply turn it on in aurora and nightly?
Flags: needinfo?(bugs)
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #8)
> Jet, this bug adds pref "layout.css.style-attr-with-xml-base.disabled" to
> disable xml:base for style attribute. Could you bring this to webcompat team
> and see if they can test with this pref turned on and see if anything is
> broken? 

https://groups.google.com/forum/#!topic/mozilla.compatibility/z2syZhkI1-U

> Or do you think we can simply turn it on in aurora and nightly?

Let's see what the telemetry in bug 1344102 comes back with.
Flags: needinfo?(bugs)
(Assignee)

Comment 10

a year ago
(In reply to Jet Villegas (:jet) from comment #9)
> > Or do you think we can simply turn it on in aurora and nightly?
> 
> Let's see what the telemetry in bug 1344102 comes back with.

It comes similar bad: https://mzl.la/2noihqI

But that's not about style attribute. It is only about styled element, which includes any usage on xul, html, and svg elements.
(Assignee)

Updated

a year ago
Blocks: 1349024
(Assignee)

Updated

a year ago
Blocks: 1349059
You need to log in before you can comment on or make changes to this bug.