Closed
Bug 1345542
Opened 8 years ago
Closed 8 years ago
add BUG_COMPONENT to parser/* files
Categories
(Core :: DOM: HTML Parser, enhancement)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file, 1 obsolete file)
2.64 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
to help associate files and tests with the proper bugzilla component, adding BUG_COMPONENT to moz.build files will be helpful
Assignee | ||
Comment 1•8 years ago
|
||
these all seem to fall in html:parser or xml:
$ ./mach file-info bugzilla-component parser/**
Core :: HTML: Parser
parser/expat
parser/html
parser/htmlparser
parser/moz.build
parser/nsCharsetSource.h
Core :: XML
parser/xml
Comment 2•8 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #1)
> parser/expat
> parser/htmlparser
These should be Core :: XML. (Despite the name of the latter, its only HTML use is about:blank and the rest is XML.)
Assignee | ||
Comment 3•8 years ago
|
||
thanks Henri, I have updated the patch and now it produces:
./mach file-info bugzilla-component parser/**
Core :: HTML: Parser
parser/html
parser/moz.build
parser/nsCharsetSource.h
Core :: XML
parser/expat
parser/htmlparser
parser/xml
Feel free to do the review if you want :)
Attachment #8844993 -
Attachment is obsolete: true
Attachment #8844993 -
Flags: review?(overholt)
Attachment #8845327 -
Flags: review?(overholt)
Updated•8 years ago
|
Attachment #8845327 -
Flags: review?(overholt) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e462b3a3f776
add BUG_COMPONENT to parser/* files. r=hsivonen
Comment 5•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•