Closed Bug 1345542 Opened 3 years ago Closed 3 years ago

add BUG_COMPONENT to parser/* files

Categories

(Core :: HTML: Parser, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

to help associate files and tests with the proper bugzilla component, adding BUG_COMPONENT to moz.build files will be helpful
Attached patch add BUG_COMPONENT to parser/* (obsolete) — Splinter Review
these all seem to fall in html:parser or xml:

$ ./mach file-info bugzilla-component parser/**
Core :: HTML: Parser
  parser/expat
  parser/html
  parser/htmlparser
  parser/moz.build
  parser/nsCharsetSource.h
Core :: XML
  parser/xml
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8844993 - Flags: review?(overholt)
(In reply to Joel Maher ( :jmaher) from comment #1)
>   parser/expat
>   parser/htmlparser

These should be Core :: XML. (Despite the name of the latter, its only HTML use is about:blank and the rest is XML.)
thanks Henri, I have updated the patch and now it produces:
./mach file-info bugzilla-component parser/**
Core :: HTML: Parser
  parser/html
  parser/moz.build
  parser/nsCharsetSource.h
Core :: XML
  parser/expat
  parser/htmlparser
  parser/xml

Feel free to do the review if you want :)
Attachment #8844993 - Attachment is obsolete: true
Attachment #8844993 - Flags: review?(overholt)
Attachment #8845327 - Flags: review?(overholt)
Attachment #8845327 - Flags: review?(overholt) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e462b3a3f776
add BUG_COMPONENT to parser/* files. r=hsivonen
https://hg.mozilla.org/mozilla-central/rev/e462b3a3f776
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.