Closed Bug 1345556 Opened 3 years ago Closed 3 years ago

add BUG_COMPONENT to services/* files

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(2 files, 1 obsolete file)

this will help match bugs up to the right team if needed.
Attached patch add BUG_COMPONENT to services/* (obsolete) — Splinter Review
:rfkelly- can you verify the fxAccounts
:leplatrem - can you verify the cloud services stuff

here is the final list:
$ ./mach file-info bugzilla-component services/**
Cloud Services :: Firefox: Common
  services/blocklists
Cloud Services :: cloudSync
  services/cloudsync
Core :: Build Config
  services/moz.build
Core :: fxAccounts
  services/fxaccounts
Mozilla Services :: Firefox Sync: Backend
  services/sync
Mozilla Services :: Firefox Sync: Crypto
  services/crypto
Mozilla Services :: Firefox: Common
  services/common


* NOTE: some of this was done prior to me working on this.
Attachment #8845023 - Flags: review?(rfkelly)
Attachment #8845023 - Flags: review?(mathieu)
Thanks, Joel and Richard! For Sync, we're trying to move away from the "Cloud Services :: Firefox Sync: Backend" (and "Firefox Sync: Crypto") components, and to "Firefox :: Sync". (We triage all of them just in case, but this might be a good time to change them, too). The others look great.
Component: General → Sync
Product: Cloud Services → Firefox
thanks :kit, I have updated the patch accordingly (and realized the existing stuff referenced old components)
Assignee: nobody → jmaher
Attachment #8845023 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8845023 - Flags: review?(rfkelly)
Attachment #8845023 - Flags: review?(mathieu)
Attachment #8845035 - Flags: review?(rfkelly)
Attachment #8845035 - Flags: review?(kit)
Comment on attachment 8845035 [details] [diff] [review]
add BUG_COMPONENT to services/*

Review of attachment 8845035 [details] [diff] [review]:
-----------------------------------------------------------------

The FxA part looks good to me, thanks!
Attachment #8845035 - Flags: review?(rfkelly) → review+
Comment on attachment 8845035 [details] [diff] [review]
add BUG_COMPONENT to services/*

Review of attachment 8845035 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops, sorry I missed the r? Looks great; thanks, Joel!
Attachment #8845035 - Flags: review?(kit) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f96cfcb21a
add BUG_COMPONENT to services/* files. r=rfkelly, kit
https://hg.mozilla.org/mozilla-central/rev/a1f96cfcb21a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Sorry Joel to arrive late to the party :]

It's not crucial, but I would have put ``services/blocklists`` under *Firefox: Common*, or *Toolkit: blocklisting*, but not *Firefox :: Sync*.
sure, lets just adjust it, here is what we end up with:
$ ./mach file-info bugzilla-component services/**
Cloud Services :: Firefox: Common
  services/common
Cloud Services :: cloudSync
  services/cloudsync
Core :: Build Config
  services/moz.build
Core :: fxAccounts
  services/fxaccounts
Firefox :: Sync
  services/crypto
  services/sync
Toolkit :: Blocklisting
  services/blocklists
Attachment #8845963 - Flags: review?(mathieu)
Attachment #8845963 - Flags: review?(mathieu) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/388514801752
adjust BUG_COMPONENT for services/blocklist/* files. r=leplatrem
You need to log in before you can comment on or make changes to this bug.