1345556 - add BUG_COMPONENT to services/* files

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

this will help match bugs up to the right team if needed.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to services/*

:rfkelly- can you verify the fxAccounts
:leplatrem - can you verify the cloud services stuff

here is the final list:
$ ./mach file-info bugzilla-component services/**
Cloud Services :: Firefox: Common
  services/blocklists
Cloud Services :: cloudSync
  services/cloudsync
Core :: Build Config
  services/moz.build
Core :: fxAccounts
  services/fxaccounts
Mozilla Services :: Firefox Sync: Backend
  services/sync
Mozilla Services :: Firefox Sync: Crypto
  services/crypto
Mozilla Services :: Firefox: Common
  services/common


* NOTE: some of this was done prior to me working on this.

Comment 2

[Lina Butler [:lina]]

Thanks, Joel and Richard! For Sync, we're trying to move away from the "Cloud Services :: Firefox Sync: Backend" (and "Firefox Sync: Crypto") components, and to "Firefox :: Sync". (We triage all of them just in case, but this might be a good time to change them, too). The others look great.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to services/*

thanks :kit, I have updated the patch accordingly (and realized the existing stuff referenced old components)

Comment 4

[Ryan Kelly [:rfkelly]]

Comment on attachment 8845035 [details] [diff] [review]
add BUG_COMPONENT to services/*

Review of attachment 8845035 [details] [diff] [review]:
-----------------------------------------------------------------

The FxA part looks good to me, thanks!

Comment 5

[Lina Butler [:lina]]

Comment on attachment 8845035 [details] [diff] [review]
add BUG_COMPONENT to services/*

Review of attachment 8845035 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops, sorry I missed the r? Looks great; thanks, Joel!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f96cfcb21a
add BUG_COMPONENT to services/* files. r=rfkelly, kit

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a1f96cfcb21a

Comment 8

[Mathieu Leplatre [:leplatrem]]

Sorry Joel to arrive late to the party :]

It's not crucial, but I would have put ``services/blocklists`` under *Firefox: Common*, or *Toolkit: blocklisting*, but not *Firefox :: Sync*.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: adjust BUG_COMPONENT for services/blocklists/*

sure, lets just adjust it, here is what we end up with:
$ ./mach file-info bugzilla-component services/**
Cloud Services :: Firefox: Common
  services/common
Cloud Services :: cloudSync
  services/cloudsync
Core :: Build Config
  services/moz.build
Core :: fxAccounts
  services/fxaccounts
Firefox :: Sync
  services/crypto
  services/sync
Toolkit :: Blocklisting
  services/blocklists

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/388514801752
adjust BUG_COMPONENT for services/blocklist/* files. r=leplatrem

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/388514801752