1345583 - Move code for startup and shutdown handling of preferences to ExtensionPreferencesManager

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Bob Silverberg [:bsilverberg]]

The code that is currently in ext-privacy.js [1] for handling automatic enabling and disabling of preferences on extension startup and shutdown should be moved into ExtensionPreferencesManager.jsm.

It doesn't make sense to have this code in the individual ext- files and in fact causes a problem when more than one of those files includes the code.

[1] http://searchfox.org/mozilla-central/source/toolkit/components/extensions/ext-privacy.js#17-35

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1345583 - Move code for startup and shutdown handling of preferences to ExtensionPreferencesManager,

Review commit: https://reviewboard.mozilla.org/r/118286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118286/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8845075 [details]
Bug 1345583 - Move code for startup and shutdown handling of preferences to ExtensionPreferencesManager,

https://reviewboard.mozilla.org/r/118286/#review120294

This would be good to add tests for too, but getting the change in to unblock other consumers seems like a higher priority.

::: toolkit/components/extensions/ExtensionPreferencesManager.jsm:37
(Diff revision 1)
>  
>  XPCOMUtils.defineLazyGetter(this, "defaultPreferences", function() {
>    return new Preferences({defaultBranch: true});
>  });
>  
> +const {Management} = Cu.import("resource://gre/modules/Extension.jsm", {});

please move this to the top of the file

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8845075 [details]
Bug 1345583 - Move code for startup and shutdown handling of preferences to ExtensionPreferencesManager,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118286/diff/1-2/

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8845075 [details]
Bug 1345583 - Move code for startup and shutdown handling of preferences to ExtensionPreferencesManager,

https://reviewboard.mozilla.org/r/118286/#review120294

I wasn't that concerned about tests for this change, as it is covered by the tests for the privacy API, but I suppose it's possible for the implementation of privacy to change and leave this uncovered, so yes, it should have its own tests. I have opened https://bugzilla.mozilla.org/show_bug.cgi?id=1345847 as a follow-up.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f12a9623b445
Move code for startup and shutdown handling of preferences to ExtensionPreferencesManager, r=aswan

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f12a9623b445