1345695 - stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Bobby Holley (:bholley)]

Right now we just spinelessly return the default computed values in this case.

Turning this into an assertion would probably reveal a number of bugs, which might otherwise be harder to track down.

Comment 1

[Bobby Holley (:bholley)]

Over to heycam. If this trips a lot, prioritize diagnosing the issues and filing bugs. First priority is finding out how much work is hidden under this one.

Comment 2

[Cameron McCormack (:heycam)]

Looks like there are around 40 tests that trigger that assertion in Servo_ResolveStyle:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=204196e5f095a5eefa24188e130334b67feed300&group_state=expanded

If I make Servo_ResolvePseudoStyle also assert, I get a bunch more, but I'm not sure whether it's right to assert there.  (Is it possible we're probing for pseudo styles before we resolve styles for the element?)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afefbf844d947d8a4ba161467e90edc632b41437&group_state=expanded

Comment 3

[Bobby Holley (:bholley)]

Let's scope this issue to non-pseudos and file a followup for the pseudo stuff, since it's still a bit busted until I get time to land bug 1331047.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Bug 1345695 - stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden.

Review commit: https://reviewboard.mozilla.org/r/128388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128388/

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8856433 [details]
Bug 1345695 - stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden.

https://reviewboard.mozilla.org/r/128388/#review131222

\o/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f00f1ad996f7
stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden. r=bholley

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f04cf6bbeb74
Backed out changeset f00f1ad996f7 for touching servo/

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8856433 [details]
Bug 1345695 - stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128388/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5066979a41e
stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden. r=bholley

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b5066979a41e