Closed
Bug 1345695
Opened 6 years ago
Closed 6 years ago
stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bholley, Assigned: heycam)
References
Details
Attachments
(1 file)
Right now we just spinelessly return the default computed values in this case. Turning this into an assertion would probably reveal a number of bugs, which might otherwise be harder to track down.
|
Reporter | |
Comment 1•6 years ago
|
||
Over to heycam. If this trips a lot, prioritize diagnosing the issues and filing bugs. First priority is finding out how much work is hidden under this one.
Assignee: nobody → cam
|
Assignee | |
Comment 2•6 years ago
|
||
Looks like there are around 40 tests that trigger that assertion in Servo_ResolveStyle: https://treeherder.mozilla.org/#/jobs?repo=try&revision=204196e5f095a5eefa24188e130334b67feed300&group_state=expanded If I make Servo_ResolvePseudoStyle also assert, I get a bunch more, but I'm not sure whether it's right to assert there. (Is it possible we're probing for pseudo styles before we resolve styles for the element?) https://treeherder.mozilla.org/#/jobs?repo=try&revision=afefbf844d947d8a4ba161467e90edc632b41437&group_state=expanded
|
|
Reporter | |
Comment 3•6 years ago
|
||
Let's scope this issue to non-pseudos and file a followup for the pseudo stuff, since it's still a bit busted until I get time to land bug 1331047.
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8856433 [details] Bug 1345695 - stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden. https://reviewboard.mozilla.org/r/128388/#review131222 \o/
Attachment #8856433 -
Flags: review?(bobbyholley) → review+
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f00f1ad996f7 stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden. r=bholley
Backout by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f04cf6bbeb74 Backed out changeset f00f1ad996f7 for touching servo/
| Comment hidden (mozreview-request) |
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5066979a41e stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden. r=bholley
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b5066979a41e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•