The default bug view has changed. See this FAQ.

stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden

Assigned to



CSS Parsing and Computation
14 days ago
15 hours ago


(Reporter: bholley, Assigned: heycam)


(Depends on: 3 bugs, Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)


Right now we just spinelessly return the default computed values in this case.

Turning this into an assertion would probably reveal a number of bugs, which might otherwise be harder to track down.
Over to heycam. If this trips a lot, prioritize diagnosing the issues and filing bugs. First priority is finding out how much work is hidden under this one.
Assignee: nobody → cam

Comment 2

8 days ago
Looks like there are around 40 tests that trigger that assertion in Servo_ResolveStyle:

If I make Servo_ResolvePseudoStyle also assert, I get a bunch more, but I'm not sure whether it's right to assert there.  (Is it possible we're probing for pseudo styles before we resolve styles for the element?)
Let's scope this issue to non-pseudos and file a followup for the pseudo stuff, since it's still a bit busted until I get time to land bug 1331047.


3 days ago
Depends on: 1348746


2 days ago
Depends on: 1349134


17 hours ago
Depends on: 1349457


15 hours ago
Depends on: 1349487
You need to log in before you can comment on or make changes to this bug.