1352785 - stylo: initial styling of elements with an unresolvable -moz-binding URL value causes invalid lazy style resolution

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Cameron McCormack (:heycam)]

In should_traverse_children, we avoid traversing children of an element with a -moz-binding value when we're doing an initial styling, so that we don't wastefully style the children when they'll need to be restyled as a result of attaching the binding soon after.

The test for whether to skip traversing only looks at whether there is any url() value (since we can't resolve the URL during the parallel traversal), but the check for whether to attach the binding, in nsCSSFrameConstructor::AddFrameConstructionItemsInternal, takes into account whether the url() was able to be resolved or not.  This means that we won't end up styling those children if the URL couldn't be resolved.

Comment 1

[Cameron McCormack (:heycam)]

(This is triggering the assertions for bug 1345695 in test_value_cloning.html.)

Comment 2

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e60af5d56d89f74116734b927e8eb0715354a464

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=647a298939064688c7555405c20bedb6939ebdf4

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Bug 1352785 - stylo: Ensure children of elements with invalid -moz-binding URLs get styled.

Review commit: https://reviewboard.mozilla.org/r/125800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125800/

Comment 5

[Cameron McCormack (:heycam)]

It might be that I need to do the same in nsCSSFrameConstructor::ConstructDocElementFrame, but I haven't tested.

Comment 6

[Bobby Holley (:bholley)]

Comment on attachment 8853730 [details]
Bug 1352785 - stylo: Ensure children of elements with invalid -moz-binding URLs get styled.

https://reviewboard.mozilla.org/r/125800/#review128306

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4662b8b64e3c
stylo: Ensure children of elements with invalid -moz-binding URLs get styled. r=bholley

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4662b8b64e3c