1345751 - Label runnables in dom/media/FileBlockCache.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/78ac0ceba97bd2deed847a8d0ae86ccf7a8887bf/dom/media/FileBlockCache.cpp#77

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1345751. P1 - remove the else branch for MediaShutdownManager ensures all media activities are finished before "xpcom-shutdown-threads" starts.

Review commit: https://reviewboard.mozilla.org/r/118862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118862/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1345751. P2 - use SystemGroup to dispatch the event.

Review commit: https://reviewboard.mozilla.org/r/118864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118864/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8845711 [details]
Bug 1345751. P1 - remove the else branch for MediaShutdownManager ensures all media activities are finished before "xpcom-shutdown-threads" starts.

https://reviewboard.mozilla.org/r/118862/#review120896

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8845712 [details]
Bug 1345751. P2 - use SystemGroup to dispatch the event.

https://reviewboard.mozilla.org/r/118864/#review120898

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8681577ccf9
P1 - remove the else branch for MediaShutdownManager ensures all media activities are finished before "xpcom-shutdown-threads" starts. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/f4b04c195f3f
P2 - use SystemGroup to dispatch the event. r=cpearce

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b8681577ccf9
https://hg.mozilla.org/mozilla-central/rev/f4b04c195f3f