1345849 - Use DrawTriangles() instead of DrawTriangle() in OpenGL compositor backend

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P3)

Description

[Miko Mynttinen]

This is an optimization related to bug 1286412.

The compositor changes introduced in bug 1323797 and bug 1323791 would allow rendering polygons in OpenGL compositor with a single DrawTriangles() call instead of multiple DrawTriangle() calls. For complex scenes, this would reduce draw calls and state changes, improving performance.

This is already done in BasicCompositor and CompositorD3D11.

Comment 1

[Miko Mynttinen]

Attachment: Bug 1345849 - Part 1: Use DrawTriangles() instead of DrawTriangle() in OpenGL compositor backend

Review commit: https://reviewboard.mozilla.org/r/123972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123972/

Comment 2

[Miko Mynttinen]

Attachment: Bug 1345849 - Part 2: Remove unused Triangle::width and height

Review commit: https://reviewboard.mozilla.org/r/123974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123974/

Comment 3

[Miko Mynttinen]

This patch improves OpenGL compositing performance by up to 10%.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8851746 [details]
Bug 1345849 - Part 2: Remove unused Triangle::width and height

https://reviewboard.mozilla.org/r/123974/#review127360

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8851745 [details]
Bug 1345849 - Part 1: Use DrawTriangles() instead of DrawTriangle() in OpenGL compositor backend

https://reviewboard.mozilla.org/r/123972/#review132106

Comment 6

[Miko Mynttinen]

Thank you for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db1754a0b9da3ecc4cc9b88254e90e0f44557112

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c39953270c30
Part 1: Use DrawTriangles() instead of DrawTriangle() in OpenGL compositor backend r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6d21cafb2879
Part 2: Remove unused Triangle::width and height r=jrmuizel

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c39953270c30
https://hg.mozilla.org/mozilla-central/rev/6d21cafb2879