1323797 - Add compositor support for triangle layers (for BasicCompositor backend)

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Miko Mynttinen]

This bug tracks the implementation of bug 1285380 for BasicCompositor backend.

Comment 1

[Miko Mynttinen]

Attachment: Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 1: Replace DrawQuad with DrawGeometry

Review commit: https://reviewboard.mozilla.org/r/104040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104040/

Comment 2

[Miko Mynttinen]

Attachment: Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 2: Add DrawTriangles() and DrawPolygon()

Review commit: https://reviewboard.mozilla.org/r/104042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104042/

Comment 3

[Miko Mynttinen]

Attachment: Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 3: Implement DrawPolygon() with Paths

Review commit: https://reviewboard.mozilla.org/r/104044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104044/

Comment 4

[Miko Mynttinen]

Attachment: Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 4: Add reftests for plane splitting

Review commit: https://reviewboard.mozilla.org/r/104046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104046/

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8825998 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 1: Replace DrawQuad with DrawGeometry

https://reviewboard.mozilla.org/r/104040/#review104784

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8825999 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 2: Add DrawTriangles() and DrawPolygon()

https://reviewboard.mozilla.org/r/104042/#review104786

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8826000 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 3: Implement DrawPolygon() with Paths

https://reviewboard.mozilla.org/r/104044/#review104790

Comment 8

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8826001 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 4: Add reftests for plane splitting

https://reviewboard.mozilla.org/r/104046/#review104800

::: layout/reftests/transform-3d/reftest.list:84
(Diff revision 1)
>  fuzzy(1,10000) == opacity-preserve3d-4.html opacity-preserve3d-4-ref.html
>  == snap-perspective-1.html snap-perspective-1-ref.html
>  == mask-layer-1.html mask-layer-ref.html
>  == mask-layer-2.html mask-layer-ref.html
>  == mask-layer-3.html mask-layer-ref.html
> +fails-if(winWidget) == split-intersect1.html split-intersect1-ref.html

Is there a bug open for getting windows support?

If not, please file one, and then mention the bug number as a comment here.

Comment 9

[Miko Mynttinen]

Comment on attachment 8825998 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 1: Replace DrawQuad with DrawGeometry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104040/diff/1-2/

Comment 10

[Miko Mynttinen]

Comment on attachment 8825999 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 2: Add DrawTriangles() and DrawPolygon()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104042/diff/1-2/

Comment 11

[Miko Mynttinen]

Comment on attachment 8826000 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 3: Implement DrawPolygon() with Paths

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104044/diff/1-2/

Comment 12

[Miko Mynttinen]

Comment on attachment 8826001 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 4: Add reftests for plane splitting

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/104046/diff/1-2/

Comment 13

[Miko Mynttinen]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6141d22868ca21348b831fa68d4307d9314ba82d

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da1dd080a5e1
Add compositor support for triangle layers (for BasicCompositor backend) - Part 1: Replace DrawQuad with DrawGeometry r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/13dc18dc8286
Add compositor support for triangle layers (for BasicCompositor backend) - Part 2: Add DrawTriangles() and DrawPolygon() r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/99007c4ee7ea
Add compositor support for triangle layers (for BasicCompositor backend) - Part 3: Implement DrawPolygon() with Paths r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/bfa926f42cc5
Add compositor support for triangle layers (for BasicCompositor backend) - Part 4: Add reftests for plane splitting r=mattwoodrow

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da1dd080a5e1
https://hg.mozilla.org/mozilla-central/rev/13dc18dc8286
https://hg.mozilla.org/mozilla-central/rev/99007c4ee7ea
https://hg.mozilla.org/mozilla-central/rev/bfa926f42cc5