If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add compositor support for triangle layers (for BasicCompositor backend)

RESOLVED FIXED in Firefox 53

Status

()

Core
Graphics: Layers
RESOLVED FIXED
9 months ago
11 days ago

People

(Reporter: miko, Assigned: miko)

Tracking

(Depends on: 1 bug)

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

9 months ago
This bug tracks the implementation of bug 1285380 for BasicCompositor backend.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

9 months ago
mozreview-review
Comment on attachment 8825998 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 1: Replace DrawQuad with DrawGeometry

https://reviewboard.mozilla.org/r/104040/#review104784
Attachment #8825998 - Flags: review?(matt.woodrow) → review+

Comment 6

9 months ago
mozreview-review
Comment on attachment 8825999 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 2: Add DrawTriangles() and DrawPolygon()

https://reviewboard.mozilla.org/r/104042/#review104786
Attachment #8825999 - Flags: review?(matt.woodrow) → review+

Comment 7

9 months ago
mozreview-review
Comment on attachment 8826000 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 3: Implement DrawPolygon() with Paths

https://reviewboard.mozilla.org/r/104044/#review104790
Attachment #8826000 - Flags: review?(matt.woodrow) → review+

Comment 8

9 months ago
mozreview-review
Comment on attachment 8826001 [details]
Bug 1323797 - Add compositor support for triangle layers (for BasicCompositor backend) - Part 4: Add reftests for plane splitting

https://reviewboard.mozilla.org/r/104046/#review104800

::: layout/reftests/transform-3d/reftest.list:84
(Diff revision 1)
>  fuzzy(1,10000) == opacity-preserve3d-4.html opacity-preserve3d-4-ref.html
>  == snap-perspective-1.html snap-perspective-1-ref.html
>  == mask-layer-1.html mask-layer-ref.html
>  == mask-layer-2.html mask-layer-ref.html
>  == mask-layer-3.html mask-layer-ref.html
> +fails-if(winWidget) == split-intersect1.html split-intersect1-ref.html

Is there a bug open for getting windows support?

If not, please file one, and then mention the bug number as a comment here.
Attachment #8826001 - Flags: review?(matt.woodrow) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 13

8 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6141d22868ca21348b831fa68d4307d9314ba82d
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 14

8 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/da1dd080a5e1
Add compositor support for triangle layers (for BasicCompositor backend) - Part 1: Replace DrawQuad with DrawGeometry r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/13dc18dc8286
Add compositor support for triangle layers (for BasicCompositor backend) - Part 2: Add DrawTriangles() and DrawPolygon() r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/99007c4ee7ea
Add compositor support for triangle layers (for BasicCompositor backend) - Part 3: Implement DrawPolygon() with Paths r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/bfa926f42cc5
Add compositor support for triangle layers (for BasicCompositor backend) - Part 4: Add reftests for plane splitting r=mattwoodrow
Keywords: checkin-needed

Comment 15

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/da1dd080a5e1
https://hg.mozilla.org/mozilla-central/rev/13dc18dc8286
https://hg.mozilla.org/mozilla-central/rev/99007c4ee7ea
https://hg.mozilla.org/mozilla-central/rev/bfa926f42cc5
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Depends on: 1331894
(Assignee)

Updated

8 months ago
Blocks: 1285380
Depends on: 1335159
Blocks: 1187209
Depends on: 1399268
You need to log in before you can comment on or make changes to this bug.