Incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: johannh, Assigned: meghanagupta3, Mentored)

Tracking

Trunk
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox52 wontfix, firefox53 wontfix, firefox54 fix-optional, firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Example: https://pinning-test.badssl.com/

The "learn more" link should lead to: https://support.mozilla.org/t5/Documents-Archive/Certificate-Pinning-Reports/ta-p/29236

It doesn't.

This is because in this line http://searchfox.org/mozilla-central/rev/78ac0ceba97bd2deed847a8d0ae86ccf7a8887bf/browser/base/content/aboutNetError.xhtml#258 we compare against mozilla_pkix_error_key_pinning_failure  instead of MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE.

So someone needs to change the lowercase to uppercase. :)

(Note that I find the SUMO page for pinning not very useful, we should alert someone about that)
> (Note that I find the SUMO page for pinning not very useful, we should alert
> someone about that)
Needinfo jsavage for that, maybe in a new bug.
(Assignee)

Comment 2

2 years ago
Hi, can I be assigned this bug?
Ok, the bug is yours. If you have questions, please ask.
Assignee: nobody → meghanagupta3
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 years ago
I don't need to do anything but change "mozilla_pkix_error_key_pinning_failure" to uppercase, right? I don't have to file the new bug or anything else?
(Reporter)

Comment 5

2 years ago
(In reply to Meghana Gupta from comment #4)
> I don't need to do anything but change
> "mozilla_pkix_error_key_pinning_failure" to uppercase, right? I don't have
> to file the new bug or anything else?

I can take care of making a bug for SUMO. :)
(Reporter)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8847707 [details]
Bug 1346236 - Fixed incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE in aboutNetError.xhtml.

https://reviewboard.mozilla.org/r/120634/#review122918

Thanks!

I'll trigger a try and set checkin-needed.
Attachment #8847707 - Flags: review?(jhofmann) → review+
(Reporter)

Updated

2 years ago
Keywords: checkin-needed

Comment 8

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/def742483f0b
Fixed incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE in aboutNetError.xhtml. r=johannh
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/def742483f0b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Reporter)

Updated

2 years ago
See Also: → 1348130
marking fix-optional for 54 because I'm not sure the new page is all that helpful in its current state.
You need to log in before you can comment on or make changes to this bug.