1346236 - Incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE

Status: RESOLVED FIXED

(Firefox :: Security, enhancement)

Description

[Johann Hofmann [:johannh]]

Example: https://pinning-test.badssl.com/

The "learn more" link should lead to: https://support.mozilla.org/t5/Documents-Archive/Certificate-Pinning-Reports/ta-p/29236

It doesn't.

This is because in this line http://searchfox.org/mozilla-central/rev/78ac0ceba97bd2deed847a8d0ae86ccf7a8887bf/browser/base/content/aboutNetError.xhtml#258 we compare against mozilla_pkix_error_key_pinning_failure  instead of MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE.

So someone needs to change the lowercase to uppercase. :)

(Note that I find the SUMO page for pinning not very useful, we should alert someone about that)

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

> (Note that I find the SUMO page for pinning not very useful, we should alert
> someone about that)
Needinfo jsavage for that, maybe in a new bug.

Comment 2

[Meghana Gupta]

Hi, can I be assigned this bug?

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Ok, the bug is yours. If you have questions, please ask.

Comment 4

[Meghana Gupta]

I don't need to do anything but change "mozilla_pkix_error_key_pinning_failure" to uppercase, right? I don't have to file the new bug or anything else?

Comment 5

[Johann Hofmann [:johannh]]

(In reply to Meghana Gupta from comment #4)
> I don't need to do anything but change
> "mozilla_pkix_error_key_pinning_failure" to uppercase, right? I don't have
> to file the new bug or anything else?

I can take care of making a bug for SUMO. :)

Comment 6

[Meghana Gupta]

Attachment: Bug 1346236 - Fixed incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE in aboutNetError.xhtml.

Review commit: https://reviewboard.mozilla.org/r/120634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120634/

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8847707 [details]
Bug 1346236 - Fixed incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE in aboutNetError.xhtml.

https://reviewboard.mozilla.org/r/120634/#review122918

Thanks!

I'll trigger a try and set checkin-needed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/def742483f0b
Fixed incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE in aboutNetError.xhtml. r=johannh

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/def742483f0b

Comment 10

[Julien Cristau [:jcristau]]

marking fix-optional for 54 because I'm not sure the new page is all that helpful in its current state.