Closed
Bug 1346331
Opened 8 years ago
Closed 8 years ago
Remove non-existent borders and backgrounds in toolbox/toolbar after bug 1343196
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file, 2 obsolete files)
|
10.71 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
Bug 1343196 removed background-color and border definitions. We have still some resets in our tree which can be removed now.
|
Assignee | |
Comment 1•8 years ago
|
||
Most removals are on Windows. That's also why I added Jörg for f? because it's better two more eyes check there is no regression.
Linux and OSX are code cleanup.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8846069 -
Flags: review?(mkmelin+mozilla)
Attachment #8846069 -
Flags: feedback?(jorgk)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8846069 [details] [diff] [review]
toolboxCleanup.patch
I looked at the main window, a message header in the preview pane and in a tab, a compose window and the address book window. All look normal. What else should I look at?
Attachment #8846069 -
Flags: feedback?(jorgk) → feedback+
|
|
Assignee | |
Comment 3•8 years ago
|
||
That's fine, everywhere where is a toolbar. The places you wrote are okay. Thank you.
|
|
Assignee | |
Comment 4•8 years ago
|
||
Added removal of no more needed Linux statusbarpanel border after bug 1348137 (awaiting check-in).
Attachment #8846069 -
Attachment is obsolete: true
Attachment #8846069 -
Flags: review?(mkmelin+mozilla)
Attachment #8848805 -
Flags: review?(mkmelin+mozilla)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8848805 [details] [diff] [review]
toolboxCleanup.patch
I checked the Windows part. Perhaps Aceman can give it a quick whirl and then we'll land it.
Attachment #8848805 -
Flags: review?(mkmelin+mozilla)
Attachment #8848805 -
Flags: review?(acelists)
Attachment #8848805 -
Flags: review+
Comment on attachment 8848805 [details] [diff] [review]
toolboxCleanup.patch
Review of attachment 8848805 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, I see no obvious breakage.
I wonder when they fix the ugly resizer corner icon in gtk3. Probably never if statusbar is not used in FF.
Attachment #8848805 -
Flags: review?(acelists) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Updated the reviewers.
Thank you aceman and Jörg.
Attachment #8848805 -
Attachment is obsolete: true
Attachment #8852321 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
|
||
Comment 8•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in
before you can comment on or make changes to this bug.
Description
•