Closed Bug 1346390 Opened 5 years ago Closed 5 years ago
[findbugs] Boxing/unboxing to parse a primitive org
.mozilla .gecko .fxa .authenticator .Android Fx Account .get Device Registration Timestamp()
59 bytes, text/x-review-board-request
1.68 KB, patch
|Details | Diff | Splinter Review|
A follow-up for Bug 1329793.
Comment on attachment 8846113 [details] Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency https://reviewboard.mozilla.org/r/119196/#review121168
Attachment #8846113 - Flags: review?(nalexander) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/378722287469 Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander
Follow up for Bug 1329793. [Feature/Bug causing the regression]: Bug 1329793 [User impact if declined]: findbugs complains in automation [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: no [Is the change risky?]: no [Why is the change risky/not risky?]: One line fix, changing which static method of Long is used for parsing. [String changes made/needed]: no
Comment on attachment 8850090 [details] [diff] [review] unboxing-fix-beta.patch Fix for test failure issues for FxA/sync. Let's uplift this so we can bring up some other fixes for send to tabs.
Setting qe-verify- based on comment 6.
You need to log in before you can comment on or make changes to this bug.