1346390 - [findbugs] Boxing/unboxing to parse a primitive org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.getDeviceRegistrationTimestamp()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Firefox Accounts, defect)

Description

[:Grisha Kruglov]

A follow-up for Bug 1329793.

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency

Review commit: https://reviewboard.mozilla.org/r/119196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119196/

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8846113 [details]
Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency

https://reviewboard.mozilla.org/r/119196/#review121168

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/378722287469
Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/378722287469

Comment 6

[:Grisha Kruglov]

Attachment: unboxing-fix-beta.patch

Follow up for Bug 1329793.

[Feature/Bug causing the regression]: Bug 1329793

[User impact if declined]: findbugs complains in automation

[Is this code covered by automated tests?]: no

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: no

[List of other uplifts needed for the feature/fix]: no

[Is the change risky?]: no

[Why is the change risky/not risky?]: One line fix, changing which static method 
of Long is used for parsing.

[String changes made/needed]: no

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8850090 [details] [diff] [review]
unboxing-fix-beta.patch

Fix for test failure issues for FxA/sync. Let's uplift this so we can bring up some other fixes for send to tabs.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cd04c51ec1d7

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/22b13a98b585

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

Setting qe-verify- based on comment 6.