[unifiedcomplete] The first suggestion randomly displays autofilled text, so Enter doesn't apply to text in location bar

NEW
Unassigned

Status

()

Firefox
Location Bar
P3
normal
4 months ago
4 months ago

People

(Reporter: 684sigma, Unassigned)

Tracking

({ux-efficiency})

34 Branch
ux-efficiency
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxsearch])

(Reporter)

Description

4 months ago
I have a problem with Firefox Beta 52. It doesn't happen in Firefox 28.
Sometimes first suggestion is constructed from the typed search term and autofilled value, even if it was deleted.
It happens unpredictably, however, I noticed two specific scenarios when it happens

1. Open new tab, type in location bar "mozilla.org", navigate to mozilla.org
2. Open new tab, type in location bar "mmozi", put cursor to the beginning of location bar, press Delete

1. Open new tab, type in location bar "mozilla.org", navigate to mozilla.org
2. Open new tab, type in location bar "mozi", press Delete to delete autofilled value "lla.org/"
3. Click on the web page then click in location bar. Press Down to show suggestions

Result: first suggestion says "mozilla.org/ - Visit"
Expected: "mozi - Search in Google"+
location bar autofill
eexample -> delete first "e" => url suggesion navigate to "example.org"

Updated

4 months ago
Blocks: 995091
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true
Keywords: ux-efficiency
Summary: Regression First suggestions adds autofilled value to the typed search term and brings confusion (sometimes) → [unifiedcomplete] The first suggestion should be search instead of visit, if the autofilled domain has been removed
Version: 52 Branch → 34 Branch
(Reporter)

Comment 1

4 months ago
First of all, all text in the first comment starting from "location bar autofill" is useless, ignore it.
Secondly, original summary was too general, but the new summary is incorrect: (1) in the first scenario I don't "remove" autofilled domain, it just appears without reason, (2) autofill doesn't only work for domains, it also autofills urls like "http://bugzilla.mozilla.org/sho" -> "http://bugzilla.mozilla.org/show_bug.cgi".


YF (Yang), I've read your bug 1346428, Comment 1, and (due to confusion caused by my actions) it applies to this bug; so I think this is just misunderstanding. So I'll answer to it in this bug.

(In reply to YF (Yang) from comment #1)
> I'm not sure if this bug is true, because even after you Delete that, press
> the Enter key will still open the autofilled domain.

This is especially bad, because I'm looking at the text typed in location bar, and in normal circumstances pressing Enter should search for typed text, unless it's a url. If I hide suggestion, then pressing Enter searches for "mozi", as expected. So far I noticed that Enter always executes selected suggestion, so wrong suggestion seems to be the root cause.

> I removes the "Regression" from summary, because it is a issue due to new
> introduction, though maybe this is regarded as regression. I added the
> "blocks" to make sure it is not ignored as much as possible.

If only it was pure "new introduction", but it has broken many aspects, including pressing Enter in location bar (see your own comment above and my comments). Somehow I forgot to mention that in the summary and description, but as I said, it's super bad. Thanks for blocking making it less ignored.
Summary: [unifiedcomplete] The first suggestion should be search instead of visit, if the autofilled domain has been removed → [unifiedcomplete] The first suggestion randomly displays autofilled text, so Enter doesn't apply to text in location bar

Updated

4 months ago
Priority: -- → P3
Whiteboard: [fxsearch]
You need to log in before you can comment on or make changes to this bug.