Closed Bug 1346441 Opened 5 years ago Closed 1 year ago

Add basic Command Support for Matrix.

Categories

(Chat Core :: Matrix, enhancement)

enhancement
Not set
normal

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
88 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: matrixisreal, Assigned: freaktechnik)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → pavankarthikboddeda
Moving Matrix bugs to the new Matrix component.
Component: General → Matrix
Depends on: 1347202
Attached patch commands.patch (obsolete) — Splinter Review
Just the /join Command is implemented yet.
Attachment #8847584 - Flags: review?(clokep)
Comment on attachment 8847584 [details] [diff] [review]
commands.patch

Review of attachment 8847584 [details] [diff] [review]:
-----------------------------------------------------------------

This needs a help string! I'm not even 100% sure what behavior to review without it. :)

::: chat/protocols/matrix/matrixCommands.jsm
@@ +13,5 @@
> +
> +// Shortcut to get the JavaScript account object.
> +function getAccount(aConv) { return getConv(aConv)._account; }
> +
> +// TODO: Some other Commands to implement.

Is there a reference for commands that UIs should implement?
Attachment #8847584 - Flags: review?(clokep) → review-
> 
> This needs a help string! I'm not even 100% sure what behavior to review
> without it. :)
> 

Yeah, I totally forgot.
Anyway, its somwthing like join <param> [<param>*]

> > +// TODO: Some other Commands to implement.
> 
> Is there a reference for commands that UIs should implement?

At the time of writing the patch, I just wrote some random commands which I thought might be helpful,
But the commands on Riot can be considered as A first reference, but we might add others if we find them useful/necessary for our interface.
Depends on: 1394397
Assignee: pavankarthikboddeda → nobody
Assignee: nobody → khushil324
Attachment #9191641 - Attachment is obsolete: true
Attachment #8847584 - Attachment is obsolete: true
Assignee: khushil324 → martin
Status: NEW → ASSIGNED

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c7a36e074e4d
Add commands to matrix. r=clokep

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.