1346441 - Add basic Command Support for Matrix.

Status: RESOLVED FIXED

(Chat Core :: Matrix, enhancement)

Comment 1

[Patrick Cloke [:clokep]]

Moving Matrix bugs to the new Matrix component.

Comment 2

[Pavan Karthik [:matrixisreal]]

Attachment: commands.patch

Just the /join Command is implemented yet.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8847584 [details] [diff] [review]
commands.patch

Review of attachment 8847584 [details] [diff] [review]:
-----------------------------------------------------------------

This needs a help string! I'm not even 100% sure what behavior to review without it. :)

::: chat/protocols/matrix/matrixCommands.jsm
@@ +13,5 @@
> +
> +// Shortcut to get the JavaScript account object.
> +function getAccount(aConv) { return getConv(aConv)._account; }
> +
> +// TODO: Some other Commands to implement.

Is there a reference for commands that UIs should implement?

Comment 4

[Pavan Karthik [:matrixisreal]]

> This needs a help string! I'm not even 100% sure what behavior to review
> without it. :)
> 

Sorry, I forgot that. 


> 
> Is there a reference for commands that UIs should implement?

Maybe all the Riot Commands and some others which we might want to add like /leave

Comment 5

[Pavan Karthik [:matrixisreal]]

> 
> This needs a help string! I'm not even 100% sure what behavior to review
> without it. :)
> 

Yeah, I totally forgot.
Anyway, its somwthing like join <param> [<param>*]

> > +// TODO: Some other Commands to implement.
> 
> Is there a reference for commands that UIs should implement?

At the time of writing the patch, I just wrote some random commands which I thought might be helpful,
But the commands on Riot can be considered as A first reference, but we might add others if we find them useful/necessary for our interface.

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: WIP_Bug-1346441_matrix-command-support.patch

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: Bug 1346441 - Add commands to matrix. r=clokep

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7a36e074e4d
Add commands to matrix. r=clokep