1346504 - Master Password dialog box permanently blocks password field and tab until entered

Status: RESOLVED DUPLICATE of bug 1348791

(Toolkit :: Password Manager, defect)

Description

[shine [:shine]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170303012758

Steps to reproduce:

Step 0 : Don't input the Master Password initially

* Open a login form with a saved password.
* Enter the username in the username field
* Change focus to the password field


Actual results:

Changing the focus to the password field pops the Master Password modal. Canceling the modal pops another one up. This repeats unless the focus is moved away from the password field. This makes it impossible to login to any website with opening the Password Manager's lock.

PS : This was reproduced with all add-ons disabled so it cannot be my add-ons triggering the Password Manager.


Expected results:

The Master Password modal should pop up only once. It can be re-triggered if the page is refreshed and focus is brought back to the password field but only once.

Comment 2

[Loic]

STR:

1) Be sure you saved in Firefox username/password for https://accounts.google.com/Login?hl=EN (and disconnected)
2) Set Master Password
3) Restart Firefox and open https://accounts.google.com/Login?hl=EN

Result: the focus set on the password field makes the master password modal pop. But the user cannot cancel it because the prompt pops endlessly.
It's completely blocking the tab and the browser!

regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=adab5d5d0372d1a26685d6fbc59cdfc977ad76c6&tochange=1d5f138d4af7822f724903b4e4676662d12d8b4b

I guess it regressed by:
Matthew Noorenberghe — Bug 1332165 - Trim values for the purposes of 'skipEmptyFields' in _getPasswordFields. r=Dolske

Comment 3

[Matthew N. [:MattN]]

I suspect this is much more likely to be from the adjacent commit (bug 1334026) but I'll look later.

Comment 5

[Marcia Knous [:marcia]]

Adjusting tracking flags based on the fact this is a duplicate bug.