welcome_help.xhtml: wrong hyperlink to SM 2.1 Release Notes
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: RainerBielefeldNG, Assigned: njsg)
References
Details
(Whiteboard: SM2.53.3)
Attachments
(3 files, 2 obsolete files)
954 bytes,
patch
|
frg
:
feedback+
iannbugzilla
:
feedback+
|
Details | Diff | Splinter Review |
29.07 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
2.19 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Steps how to reproduce with official SeaMonkey 2.46 FINAL (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 Build 20161213183751 (Default Classic Theme) on German WIN7 64bit: 1. Launch Browser 2. <f1> for Help » WELCOME Help page appears 3. Click "Troubleshooting" heading with link Bug: opens <http://www.seamonkey-project.org/releases/seamonkey2.1/#troubleshooting> although <http://www.seamonkey-project.org/releases/seamonkey2.46/#troubleshooting> does exist a) Probably bug is much older than 2.46 b) I do not know how to find source at <https://dxr.mozilla.org/seamonkey/source/>. It's not <https://dxr.mozilla.org/seamonkey/source/suite/locales/en-US/chrome/common/help/welcome_help.xhtml>, there we have a link to <mozilla.org/start/1.5/troubleshooting/> Can someone leave a general hint in the wiki? c) Source can be found at <https://hg.mozilla.org/>
Reporter | ||
Comment 1•7 years ago
|
||
d) No obvious DUPs found with <https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=DUPs1346622&sharer_id=41036>
Reporter | ||
Comment 2•7 years ago
|
||
e) Still REPRODUCIBLE with unzipped installer of official en-US SeaMonkey 2.52a1 (NT 6.1; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0 Build 20170311002651 (Default Classic Theme) on German WIN7 64bit
Comment 3•7 years ago
|
||
The "Troubleshooting" heading with link actually opens <http://www.seamonkey-project.org/doc/troubleshooting>, which then immediately redirects to <http://www.seamonkey-project.org/releases/seamonkey2.1/#troubleshooting>. The same behavior occurs in any browser when you visit that link. There isn't a /doc/troubleshooting/ file in <https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/>, and there isn't a link for the page in the sitemap. <http://www.seamonkey-project.org/doc/troubleshooting> could be changed to redirect to the most recent version's troubleshooting page, or the "Troubleshooting" heading link could be changed to that of the individual release, but at this point I'm not sure how to implement either of those potential solutions.
Reporter | ||
Comment 4•7 years ago
|
||
Still REPRODUCIBLE with unzipped installer of UNofficial (by FRG) en-US SeaMonkey 2.52a1 (NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 Build 20170529113726 (Default Classic Theme) on German WIN7 64bit NEW due to <https://unofficialseamonkeynews.wordpress.com/2016/08/04/my-unconfirmed-bug-reports/>
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
The /doc/troubleshooting redirect seems to be defined in src/.htaccess,
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/file/tip/src/.htaccess#l25
Assignee | ||
Comment 6•4 years ago
|
||
While the redirect itself can be updated, this patch tries to add a separate variable so that the troubleshooting link can work like the release notes one.
Assignee | ||
Comment 7•4 years ago
|
||
And a patch to update the server-side redirect to point to 2.53.1.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 8•4 years ago
|
||
Reassign due to facts
Assignee | ||
Comment 9•4 years ago
|
||
"The same" as attachment 9145241 [details] [diff] [review] but for l10n packages.
If nothing breaks, this would also solve the problem with outdated "troubleshooting" links that are present in some packages.
Comment 10•4 years ago
|
||
Comment on attachment 9145245 [details] [diff] [review] website src/.htaccess patch to update the redirect [Checked in: Comment 12] This corrects this issue but I think we need more work on .htaccess as we need to redirect to correct protocol, so if it is http go to http and https to https. Most redirects seem to put everything to http, but this work will need to be in a new bug rather than polluting this one.
Comment 11•4 years ago
|
||
Comment on attachment 9145241 [details] [diff] [review] Adds a variable for the troubleshooting URL One more change is needed, if you look at what is in place for app.releaseNotesURL in suite-prefs.js and do the same for app.troubleshootingURL https://dxr.mozilla.org/comm-esr60/source/suite/app/profile/suite-prefs.js#489 f=me
Comment 12•4 years ago
|
||
Comment on attachment 9145245 [details] [diff] [review] website src/.htaccess patch to update the redirect [Checked in: Comment 12] ># HG changeset patch ># User Nuno Silva (njsg) You will need to update your username for the website repo.
Comment 13•4 years ago
|
||
Comment on attachment 9145245 [details] [diff] [review] website src/.htaccess patch to update the redirect [Checked in: Comment 12] https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/b36c9390cbd915d17294a8968b92ee7f2e7a9144 https://gitlab.com/seamonkey-project/website/-/commit/e045196c8e74c6cb6ad8a908946c52bb2335bf8c
Assignee | ||
Comment 14•4 years ago
|
||
Assignee | ||
Comment 15•4 years ago
|
||
(Adds app.troubleshootingURL to suite-prefs.js)
Assignee | ||
Updated•4 years ago
|
Comment 16•4 years ago
|
||
Comment on attachment 9145299 [details] [diff] [review] Adds a variable for the troubleshooting URL, v1.1 [Triage Comment] LGTM r/a=me You do need to increase the diff context to 8 for patches, either in the default (.hgrc) or on each repo's .hg/hgrc
Comment 17•4 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/43f9f426e32a
Add a preference for the "troubleshooting" URL and use it in the help. r=IanN
Comment 18•4 years ago
|
||
Comment on attachment 9145245 [details] [diff] [review] website src/.htaccess patch to update the redirect [Checked in: Comment 12] Should be 2.53.2 now :)
Comment 19•4 years ago
|
||
Comment on attachment 9145271 [details] [diff] [review] Troubleshooting URL patch for l10n [Triage Comment] r/a=me
Comment 21•4 years ago
|
||
Target 2.53.3 various commits
https://gitlab.com/seamonkey-project/seamonkey-2.53-l10n/-/commits/2_53_3_beta_01/
Description
•