Closed
Bug 1641354
Opened 5 years ago
Closed 5 years ago
Need to add localisation notes to some entities in brand.properties
Categories
(SeaMonkey :: Build Config, task)
SeaMonkey
Build Config
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
RESOLVED
FIXED
seamonkey 2.76
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.4)
Attachments
(1 file)
|
1.46 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
We should be advising localisers about whether we expect them to localise in brand.properties the likes of:
- app.releaseNotesURL
- app.troubleshootingURL
- app.vendorURL
by adding notes of the format:
# LOCALIZATION NOTE (app.releaseNotesURL): Only translate this string if
# providing a localized version of the SeaMonkey website
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: n/a
Testing completed (on m-c, etc.): 2.53.4
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #9153119 -
Flags: review?(frgrahl)
Attachment #9153119 -
Flags: approval-comm-release?
Attachment #9153119 -
Flags: approval-comm-esr60?
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9153119 [details] [diff] [review]
Add some notes
LGTM
Attachment #9153119 -
Flags: review?(frgrahl)
Attachment #9153119 -
Flags: review+
Attachment #9153119 -
Flags: approval-comm-release?
Attachment #9153119 -
Flags: approval-comm-release+
Attachment #9153119 -
Flags: approval-comm-esr60?
Attachment #9153119 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/15f57f36a8dc
Need to add localisation notes to some entities in brand.properties. r=frg
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
|
||
Updated•5 years ago
|
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
tracking-seamonkey2.53:
--- → ?
tracking-seamonkey2.57esr:
--- → ?
Whiteboard: SM2.53.4
Target Milestone: --- → seamonkey 2.76
|
|
||
Comment 4•4 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/5b8cf60cab07db53f0859b48a06b6e422ad07d0c
Need to add localisation notes to some entities in brand.properties. r=frg a=frg
Target 2.53.4
You need to log in
before you can comment on or make changes to this bug.
Description
•