Closed Bug 1346734 Opened 6 years ago Closed 6 years ago

stylo: Intermittent leakcheck | default process: 16 bytes leaked (nsStringBuffer)

Categories

(Core :: CSS Parsing and Computation, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: xidorn)

Details

(Keywords: intermittent-failure, memory-leak, Whiteboard: [stockwell disabled])

Product: Chat Core → Core
Version: trunk → unspecified
Keywords: mlk
bobby: this seems a new intermittent leak in stylo tests, could you take a look, thanks!
Flags: needinfo?(bobbyholley)
Looks like this started with the landing of bug 1315601. Seems to be happening about 80% of the time so we should jump on this quickly.

Over to xidorn.
Assignee: nobody → xidorn+moz
Blocks: 1315601
Flags: needinfo?(bobbyholley) → needinfo?(xidorn+moz)
Priority: -- → P1
Summary: Intermittent leakcheck | default process: 16 bytes leaked (nsStringBuffer) → stylo: Intermittent leakcheck | default process: 16 bytes leaked (nsStringBuffer)
Component: General → CSS Parsing and Computation
The earliest push with this leak is from bug 1341690: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8949490f91a7c560485e1d5a350718924b4cb9a2&selectedJob=83324109

The URL change seems to be a more sensible candidate since bug 1315601 doesn't have much work on string stuff.

I assume heycam would know more.
Flags: needinfo?(xidorn+moz) → needinfo?(cam)
FWIW, according to my local run last night, it seems to me the leak happens inside one of layout/reftests/{dom,generated-content}. I saw them intermittently, but failed to further locate where the issue is.
Also, this bug can be from bug 1296477, which makes more sense with the generated-content bits. manish?
Flags: needinfo?(manishearth)
Yeah, that is possible as well, since the task crashes before bug 1341690's push.
No longer blocks: 1315601
It is layout/reftests/dom/xbl-children-3.xhtml leaking.

I'm going to disable this test in this bug, and file a new bug investigating the reason.
Flags: needinfo?(manishearth)
Flags: needinfo?(cam)
Filed bug 1347065.
thanks for disabling this test
Whiteboard: [stockwell disabled]
https://hg.mozilla.org/mozilla-central/rev/ce635599e0c1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.