While working on favicons I notices in a test a strange warning about an unsupported icon payload. The icon for add-ons is defined as data:image/vndmicrosofticon;base64,... This doesn't exist, the right one would be data:image/vnd.microsoft.icon;base64,... see http://searchfox.org/mozilla-central/rev/ef0b6a528e0e7b354ddf8cdce08392be8b8ca679/browser/locales/generic/profile/bookmarks.html.in#18
Comment on attachment 8849965 [details] Bug 1346736 - invalid icon in default bookmarks. https://reviewboard.mozilla.org/r/122734/#review124940 Looks good. r=Standard8
Attachment #8849965 - Flags: review?(standard8) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/38793c4f8af1 invalid icon in default bookmarks. r=standard8
Comment on attachment 8849965 [details] Bug 1346736 - invalid icon in default bookmarks. Approval Request Comment [Feature/Bug causing the regression]: Bug 1283076 [User impact if declined]: One of the default bookmarks for new profiles has an invalid icon [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: I verified that the new icon data uri works [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: just fixing an icon data uri [String changes made/needed]: no
Comment on attachment 8849965 [details] Bug 1346736 - invalid icon in default bookmarks. Fix an invalid icon issue. Aurora54+ & Beta53+.
You need to log in before you can comment on or make changes to this bug.