1368451 - "Nightly Tester Tools" favicon is missing

Status: VERIFIED FIXED

(Toolkit :: Places, defect, P2)

Description

[Hani Yacoub]

Attachment: favicon - nightly tester tools.png

[Affected versions]: 
Nightly 55.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Ubuntu 16.04 and Mac OS X 10.12

[Steps to reproduce]:
1. Launch Firefox.
2. Click on "Show your bookmarks" near search bar.
3. Click on "View Bookmarks Sidebar".
4. Click on "Firefox Nightly Resources" from "Bookmarks Menu".

[Expected result]:
"Nightly Tester Tools" favicon should be displayed.

[Actual result]:
"Nightly Tester Tools" favicon is missing from Firefox Nightly resources.

Comment 1

[Marco Bonardo [:mak]]

Is this really related to bug 977177?
I ask because bug 1346736 fixed the icon that was completely broken (and thus not working) on old profiles.

Is it still broken in a new profile or was this a migrated profile?

Comment 2

[Hani Yacoub]

I logged this bug while testing on a new profile, and I couldn't reproduce it on Nightly 53.0a1.

I observed that when I click on "Nightly Tester Tools" link in bookmarks sidebar, after the link is opened "Nightly Tester Tools" favicon appear.

Comment 3

[Marco Bonardo [:mak]]

To be investigated, this is the same icon we already have problems with in bug 1346736.

Comment 4

[Marco Bonardo [:mak]]

Looks like that icon is STILL broken, because even if fixed the typo in the mimetype, the mimetyp is completely wrong!

That's a png, not an ico file.

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1368451 - Nightly Tester Tool default bookmark icon is missing.

Review commit: https://reviewboard.mozilla.org/r/144898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144898/

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8873509 [details]
Bug 1368451 - Nightly Tester Tool default bookmark icon is missing.

https://reviewboard.mozilla.org/r/144898/#review148846

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c407f01edac
Nightly Tester Tool default bookmark icon is missing. r=Felipe

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5c407f01edac

Comment 9

[Hani Yacoub]

Build ID: 20170607030206
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.