1346820 - [Top Tabs] Two tabs will be in focus when a new tab is opened via 'View later' or 'Push Notification'

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P3)

Description

[Simon Basca [:SimonB]]

Build: 7.0b2011
Device: iPad Pro 
iOS: 10.2.1

Steps to reproduce:
1. Open Firefox
2. Go to youtube
3. Tap the 'Share' button
4. Tap on 'View later'
5. Background Firefox by pressing the Home button
6. Restore Firefox


Actual results:
- Two tabs will be in focus.

Expected results:
- Only the newly opened tab should be in focus. 

See video: https://www.youtube.com/watch?v=7SgE9dc4wWA

Comment 1

[Maurya Talisetti]

Simon, can you give me permissions to watch the youtube video? I'm also sending you an email.

I wanted to check out the video because when I try to reproduce, I see something else. I don't see both the tabs focused. I see one tab focused and the other tab locked (not tappable). Also, the other tab title is "New Tab".

Comment 2

[Simon Basca [:SimonB]]

I have granted permission to the video.

Comment 3

[Maurya Talisetti]

Thanks Simon. Yes, something is not right with the "View Later" behavior.

Here's my observation:
On restoring Firefox, the tab that we wanted to "View Later" gets loaded. But, the focus is on the previously focused tab prior to backgrounding Firefox. It's not on the newly created tab though as you had observed. If you try to open more tabs, the focus is on both the newly created tab and on the previously focused tab.

Comment 4

[Maurya Talisetti]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2580

Farhan, I couldn't test the XCUI ones because I'm unable to run test cases on Xcode. I haven't seen this behavior before. When I run TopTabsTest.swift, it builds alright, then tries running on the simulator, and fails reporting the following error:

Test target XCUITests encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted)

Wondering if others are seeing this issue or if it's just me. I have Xcode 8.2.1 running on macOS 10.11.5 (El Capitan).

The BuddyBuild logs also don't show the XCUI tests. Not sure if they were disabled from running.

Comment 5

[Maurya Talisetti]

review ping

Comment 6

[Farhan Patel [:farhan]]

Left a comment on the PR.

Comment 7

[Catalin Suciu [:csuciu]]

The same issue can be reproduced by opening a new tab via push notification.

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Landed on master, uplifted to v8.x

The full reload is not ideal, but I think this is better than a UI regression that is very noticable. Thank you Maurya for contributing this patch.

Comment 9

[Simon Basca [:SimonB]]

Verifying as fix on 8.0 (4534).