Crash on "Close all tabs" on the iPad

VERIFIED FIXED

Status

()

Firefox for iOS
Menu and Toolbar
P1
critical
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: ugarlapati, Assigned: farhan)

Tracking

({crash, regression, reproducible})

unspecified
All
iOS
crash, regression, reproducible

Firefox Tracking Flags

(fxios8.1+, fxios-v8.0 affected, fxios-v9.0 verified)

Details

(Whiteboard: [MobileCore][Regression][TopTabs])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review | Splinter Review
(Reporter)

Description

a year ago
Issue is related to iPad

1. Open the app
2. Open more than 2 tabs
3. Go to tabs screen
4. Click on menu button
5. Click on Close All Tabs button

Noticed App crashes.

This issue occurs only in iPad.

Tested on iPadAir 2 simulator
Reproducible: 10/10
Stack Trace:
    2017-07-19 11:24:54.449 Client[81360:1760671] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'attempt to delete item 2 from section 0 which only contains 1 items before the update'
    *** First throw call stack:
    (
        0   CoreFoundation                      0x000000010de5cb0b __exceptionPreprocess + 171
        1   libobjc.A.dylib                     0x000000010d21a141 objc_exception_throw + 48
        2   CoreFoundation                      0x000000010de60cf2 +[NSException raise:format:arguments:] + 98
        3   Foundation                          0x000000010cdb4536 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 193
        4   UIKit                               0x000000010fb41f80 -[UICollectionView _endItemAnimationsWithInvalidationContext:tentativelyForReordering:animator:] + 5843
        5   UIKit                               0x000000010fb406ce -[UICollectionView _updateRowsAtIndexPaths:updateAction:] + 372
        6   UIKit                               0x0000000126f2b5f1 -[UICollectionViewAccessibility reloadItemsAtIndexPaths:] + 42
        7   Client                              0x000000010965985c _TFFC6Client21TopTabsViewControllerP33_3434E9307FC2B0225EF0EAC66FE8101010reloadDataFT_T_U_FT_T_ + 220
        8   Client                              0x00000001095cca17 _TTRXFo___XFdCb___ + 39
        9   UIKit                               0x000000010f2b13da +[UIView(UIViewAnimationWithBlocks) _setupAnimationWithDuration:delay:view:options:factory:animations:start:animationStateGenerator:completion:] + 572
        10  UIKit                               0x000000010f2b194c +[UIView(UIViewAnimationWithBlocks) animateWithDuration:animations:completion:] + 86
        11  Client                              0x000000010964f526 _TFC6Client21TopTabsViewControllerP33_3434E9307FC2B0225EF0EAC66FE8101010reloadDatafT_T_ + 1158
        12  Client                              0x0000000109659098 _TFFC6Client21TopTabsViewController14updateTabsFromFTGSqGSaCS_3Tab__2toGSaS1__2onGSqFT_T___T_U2_FSbT_ + 152
        13  Client                              0x00000001095d16d3 _TTRXFo_dSb__XFdCb_dSb__ + 51
        14  Foundation                          0x000000010cd65328 __NSFireDelayedPerform + 409
        15  CoreFoundation                      0x000000010ddf0454 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
        16  CoreFoundation                      0x000000010ddf00e3 __CFRunLoopDoTimer + 1011
        17  CoreFoundation                      0x000000010ddefcaa __CFRunLoopDoTimers + 266
        18  CoreFoundation                      0x000000010dde79ec __CFRunLoopRun + 1916
        19  CoreFoundation                      0x000000010dde7016 CFRunLoopRunSpecific + 406
        20  GraphicsServices                    0x0000000113e43a24 GSEventRunModal + 62
        21  UIKit                               0x000000010f1f8134 UIApplicationMain + 159
        22  Client                              0x000000010996154b main + 443
        23  libdyld.dylib                       0x00000001120f265d start + 1
        24  ???                                 0x0000000000000003 0x0 + 3
    )
    libc++abi.dylib: terminating with uncaught exception of type NSException
    (lldb)
Just verified in the simulator that this is a regression from the patch that landed in Bug 1346820.
Flags: needinfo?(sarentz)
See Also: → bug 1346820
tracking-fxios: --- → 8.1+
Priority: -- → P1
Has STR: --- → yes
status-fxios-v8.0: --- → affected
status-fxios-v9.0: --- → affected
Component: Build & Test → Menu and Toolbar
Keywords: crash, regression, reproducible
Hardware: Other → All
Summary: iPad App carshing while clicking "Close all tabs" → Crash on "Close all tabs" on the iPad
(Assignee)

Updated

a year ago
Assignee: nobody → fpatel
Iteration: --- → 1.26
(Assignee)

Comment 3

a year ago
Created attachment 8889561 [details] [review]
Pull Request
Attachment #8889561 - Flags: review?(jdarcangelo)
Attachment #8889561 - Flags: review?(jdarcangelo) → review+
Flags: needinfo?(sarentz)
Whiteboard: [MobileCore][Regression]
(Assignee)

Comment 4

a year ago
master https://github.com/mozilla-mobile/firefox-ios/commit/44f653078b05c6bee6a3dfe7da16fa82fbea79be
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Whiteboard: [MobileCore][Regression] → [MobileCore][Regression][needsuplift]
Verifying as fix on master 35383ea5.
Status: RESOLVED → VERIFIED
status-fxios-v9.0: affected → verified
Uplifted to v8.x
Whiteboard: [MobileCore][Regression][needsuplift] → [MobileCore][Regression]
Whiteboard: [MobileCore][Regression] → [MobileCore][Regression][TopTabs]
You need to log in before you can comment on or make changes to this bug.