1347035 - Remove PBrowser::Msg_GetMaxTouchPoints

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[(no longer active)]

The only widget layers that currently implement this are Android and Windows and they both return a constant number!  We shouldn't be doing a sync IPC for this.

Comment 1

[(no longer active)]

I wrote a patch for this one and it's pretty straightforward, but this touches on the code where we create a TabChild in the child process and send a PBrowser constructor to the parent for it which I have touched in bug 1343728.  In that code we need to get the max touch points from the widget in the parent process and I'm planning to piggy back on the code I have in bug 1343728 for the work I need to do here, so I will finish my work there before resuming the work here.

Comment 2

[Andrew Overholt [:overholt]]

Maybe Stone can take this since you're a bit busy, Ehsan.

Comment 3

[Ming-Chou Shih [:stone]]

I'd love to take this. I guess I should wait for bug 1343728 and base on the patches of it, right?

Comment 4

[Andrew Overholt [:overholt]]

(In reply to Ming-Chou Shih [:stone] from comment #3)
> I'd love to take this. I guess I should wait for bug 1343728 and base on the
> patches of it, right?

Comment 5

[(no longer active)]

(In reply to Ming-Chou Shih [:stone] from comment #3)
> I'd love to take this. I guess I should wait for bug 1343728 and base on the
> patches of it, right?

Sorry for the long delay in responding Stone.  I already have a semi-complete patch for this, but it does touch the same code as bug 1343728 so I have decided to finish that before resuming it.  Finishing this is pretty easy so as soon as I finish working on bug 1343728 I will get back to this one, I'm not too worried about it.  I just don't want anything to bitrot my patches there.  :-)

Comment 6

[(no longer active)]

Attachment: Store the maximum touch points for each tab child on the object instead of querying it synchronously from the parent actor when neeeded

Comment 7

[(no longer active)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ce960901b1499b1560d84b043424298b59958aa

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8870471 [details] [diff] [review]
Store the maximum touch points for each tab child on the object instead of querying it synchronously from the parent actor when neeeded

+               uint32_t macTouchPoints);
max

Please modify GetMaxTouchPoints to not do extra caching, it could always just
null check tabchild and if not null get the value from it and otherwise 0.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

er, I meant this GetMaxTouchPoints
http://searchfox.org/mozilla-central/rev/6c2dbacbba1d58b8679cee700fd0a54189e0cf1b/widget/PuppetWidget.cpp#1261-1273

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67b98babb3b2
Store the maximum touch points for each tab child on the object instead of querying it synchronously from the parent actor when neeeded; r=smaug ipc-r=kanru

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/67b98babb3b2