1539497 - navigator.maxTouchPoints returns 0 in child process

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

...but it returns the right value in parent process, if one is using touch screen.
https://patrickhlauke.github.io/touch/tests/pointer-multitouch-detect.html

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

well, this isn't really bug 822898 related, but later regression.

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Olli Pettay [:smaug] from comment #1)

well, this isn't really bug 822898 related, but later regression.

e10s support was added by bug 1137555. But it seems to be broken at 2017/05 (we cannot use mozregression for older build). I suspect bug 1347035...

Comment 3

[Makoto Kato [:m_kato]]

regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5bc1c758ab57c1885dceab4e7837e58af27b998c&tochange=291a11111bdd05c5cd55dd552da4b1285ceba9b2

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3e1f6212a9be537d84ac552513ce70760dc721f

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1539497, navigator.maxTouchPoints returns 0 in child process, r=ehsan

Adding two tests, browser-chrome test to test this bug that a newly opened tab gets the right
maxTouchPoints, and another test for window.open case to ensure we don't regress that case either.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

This is a regression from bug 1347035.

We don't have very nice way to pass this kind of data around, at least not yet. Fission may make this simpler.
The patch makes TabContext to know the number of points, and BrowserChild happens to extend that class, so we can remove the getter/setter from BrowserChild.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

And need to merge to new staticprefs syntax

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1539497, navigator.maxTouchPoints returns 0 in child process, r=ehsan

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9cfb724dd9a
navigator.maxTouchPoints returns 0 in child process, r=ehsan

Comment 10

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f9cfb724dd9a