1347052 - set a display port even if we don't have a root scroll frame in MobileViewportManager::UpdateDisplayPortMargins

Status: RESOLVED INVALID

(Core :: Panning and Zooming, enhancement, P3)

Description

[Timothy Nikkel (:tnikkel)]

As suggested in bug 346109, comment 23

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[Botond Ballo [:botond]]

(In reply to Timothy Nikkel (:tnikkel) from comment #0)
> As suggested in bug 346109, comment 23

That was meant to be bug 1346109, comment 23.

It wasn't so much a suggestion, as a question: I was asking whether we should / need to do so.

What are the circumstances under which the RSF is null (to help reason about this question)?

Comment 3

[Timothy Nikkel (:tnikkel)]

To answer that question I just look at

https://dxr.mozilla.org/mozilla-central/rev/6d38ad302429c98115c354d643e81987ecec5d3c/layout/base/nsCSSFrameConstructor.cpp#2756

So XUL and print documents.

Comment 4

[Botond Ballo [:botond]]

(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> To answer that question I just look at
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> 6d38ad302429c98115c354d643e81987ecec5d3c/layout/base/nsCSSFrameConstructor.
> cpp#2756
> 
> So XUL and print documents.

Thanks. I don't believe MobileViewportManager is used in either of those scenarios, so there is no need to make this change.

Comment 5

[Botond Ballo [:botond]]

Comment on attachment 8846994 [details] [diff] [review]
patch

Review of attachment 8846994 [details] [diff] [review]:
-----------------------------------------------------------------

Per comment 4.