1347113 - Use CSS outline instead of border for XUL checkbox focus ring on Windows

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1347113 - Use CSS outline instead of border for XUL checkbox focus ring.

Review commit: https://reviewboard.mozilla.org/r/120120/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120120/

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8847078 [details]
Bug 1347113 - Use CSS outline instead of border for XUL checkbox focus ring.

https://reviewboard.mozilla.org/r/120120/#review122008

LGTM!

::: toolkit/themes/windows/global/checkbox.css:67
(Diff revision 1)
>    min-width: 13px;
>    min-height: 13px;
>    background: -moz-Field no-repeat 50% 50%;
> +  margin-inline-end: 3px;
>  }
>    

nit: while you're here, can you remove this whitespace too?

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8847078 [details]
Bug 1347113 - Use CSS outline instead of border for XUL checkbox focus ring.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/120120/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9aeb5fbd179
Use CSS outline instead of border for XUL checkbox focus ring. r=mikedeboer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d9aeb5fbd179