Closed Bug 1347275 Opened 9 years ago Closed 9 years ago

Acknowledging an alert doesn't work

Categories

(Tree Management :: Perfherder, defect)

Product:
Tree Management
Component:
Perfherder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(2 files)

[treeherder] wlach:1347275 > mozilla:master
47 bytes, text/x-github-pull-request
rwood
: review+
Details | Review
[treeherder] wlach:1347275-2 > mozilla:master
47 bytes, text/x-github-pull-request
rwood
: review+
Details | Review
It triggers a function that uses _.all, which is deprecated in the latest version of lodash
Assignee: nobody → wlachance
Attachment #8847248 - Flags: review?(rwood)
Attachment #8847248 - Flags: review?(rwood) → review+
Comment on attachment 8847272 [details] [review] [treeherder] wlach:1347275-2 > mozilla:master I cherrypicked this to production already, but this could use a rubberstamp before I push to master. I think this should fix it all. I went through the lodash "changes" earlier today to verify that nothing still applied but apparently missed "removals".
Attachment #8847272 - Flags: review?(rwood)
Comment on attachment 8847272 [details] [review] [treeherder] wlach:1347275-2 > mozilla:master LGTM
Attachment #8847272 - Flags: review?(rwood) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: