1347469 - Add gradient border support in quantum render.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Recently, I added gradient border support in webrender. So we can support it in quantum render. And most of code would be shared with background gradient. I'll wait for the finishing of background gradient before doing this.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1347469 - Add bindings for gradient border.

Review commit: https://reviewboard.mozilla.org/r/125416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125416/

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1347469 - Add support for gradient border.

Review commit: https://reviewboard.mozilla.org/r/125418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125418/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8853326 [details]
Bug 1347469 - Add bindings for gradient border.

https://reviewboard.mozilla.org/r/125416/#review128084

LGTM

::: gfx/webrender_bindings/src/bindings.rs:1264
(Diff revision 1)
>  
>  #[no_mangle]
> +pub extern "C" fn wr_dp_push_border_gradient(state: &mut WrState, rect: WrRect, clip: WrRect,
> +                                             widths: WrBorderWidths,
> +                                             start_point: WrPoint, end_point: WrPoint,
> +                                             stops: * const WrGradientStop, stops_count: usize,

nit: remove space between * and const. Same for the other function

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8853327 [details]
Bug 1347469 - Add support for gradient border.

https://reviewboard.mozilla.org/r/125418/#review128158

::: layout/painting/nsDisplayList.cpp:4822
(Diff revision 1)
> +      float outset[4];
> +      NS_FOR_CSS_SIDES(i) {
> +        slice[i] = (float)(mBorderImageRenderer->mSlice.Side(i)) / appUnitsPerDevPixel;
> +        widths[i] = (float)(mBorderImageRenderer->mWidths.Side(i)) / appUnitsPerDevPixel;
> +        outset[i] = (float)(mBorderImageRenderer->mImageOutset.Side(i)) / appUnitsPerDevPixel;
> +      }

Please move these lines outside of the switch and share them with the case above.

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Addressed comments and push to try:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=87a4a2a589a36693a59975d900eab8efb71a9ee1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/350d77ec1b74
Add bindings for gradient border. r=kats
https://hg.mozilla.org/projects/graphics/rev/b47985cfad21
Add support for gradient border. r=mattwoodrow

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/350d77ec1b74
https://hg.mozilla.org/mozilla-central/rev/b47985cfad21