Closed Bug 1355590 Opened 3 years ago Closed 3 years ago

WrRect / WrClipRegion mismatch in wr_dp_push_border_gradient and _border_radial_gradient

Categories

(Core :: Graphics: WebRender, defect, P3)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

The C signature in webrender_ffi.h takes "WrClipRegion clip" but in bindings.rs it takes "clip: WrRect". That is just plain wrong, and I missed it during review :(
Comment on attachment 8857150 [details]
Bug 1355590 - Fix WrClipRegion/WrRect mismatch in a couple of Rust FFI functions.

https://reviewboard.mozilla.org/r/129092/#review131746

Thanks for fixing this.
Attachment #8857150 - Flags: review?(mtseng) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/51a406c6f598
Fix WrClipRegion/WrRect mismatch in a couple of Rust FFI functions. r=mtseng
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.