Closed
Bug 1355590
Opened 7 years ago
Closed 7 years ago
WrRect / WrClipRegion mismatch in wr_dp_push_border_gradient and _border_radial_gradient
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
The C signature in webrender_ffi.h takes "WrClipRegion clip" but in bindings.rs it takes "clip: WrRect". That is just plain wrong, and I missed it during review :(
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=89a5b641b1a2ae6756010a917abef3ac63831d7f includes this patch
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857150 [details] Bug 1355590 - Fix WrClipRegion/WrRect mismatch in a couple of Rust FFI functions. https://reviewboard.mozilla.org/r/129092/#review131746 Thanks for fixing this.
Attachment #8857150 -
Flags: review?(mtseng) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/51a406c6f598 Fix WrClipRegion/WrRect mismatch in a couple of Rust FFI functions. r=mtseng
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/51a406c6f598
|
|
Assignee | |
Updated•7 years ago
|
status-firefox55:
--- → fixed
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•