1347478 - After the update for a WebExtension that is installed via sideloading method a user can enable the first version while the last version will be disabled in about:addons

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P5)

Description

[CosminB]

[Affected versions]:
- Firefox 55.0a1 (2017-03-14) 
- Firefox 54.0a2 (2017-03-14) 
- Firefox 53.0b2 (20170313163836) unbranded build

[Affected platforms]:
- Windows 7 64-bit
- Ubuntu 14.04 64-bit

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Create xpinstall.signatures.dev-root and set it to true.
4.Change extensions.update.background.url to point to dev server and set the update interval (extensions.update.interval) to “1”.
5.Restart the browser.
6.Install via sideloading method a WebExtension version that can be upgraded to the last WebExtension version (for example the first version (1.0) from any of these two WebExtensions https://addons-dev.allizom.org/en-US/firefox/addon/ubuntunoprompt/versions/ or 
https://addons-dev.allizom.org/en-US/firefox/addon/ubuntunopermissions/versions/ )
7.Wait for the WebExtension version 1.0 to be upgraded to 1.1
8.From the hamburger menu enable the WebExtension. 

[Expected results]:
I am not sure about the expected result but I think the background update should not be made until the user give his permission for the first version to be enabled.

[Actual results]:
After the update was made to the last version the user can enabled the version that was installed by sideloading method and the icon will be displayed in the tool bar.

[Additional notes]:
- This issue reproduces constantly
- The WebExtensions from step 6 have permissions that are not promptable or do not have any permission inside the manifest.json file. 
- Here is a video for this issue: https://www.dropbox.com/s/vmjd9lb21xfelny/Enabled.ogv?dl=0

Comment 1

[CosminB]

Attachment: SideloadUpdate.gif

If you install an Add-on version via sideloading method and make an update to a WebExtension version the result will be a bit different because the icon won’t be displayed in the favorites bar even if you restart or reopen the web page. (The icon is displayed only if you press the “Enable” button for a second time)

Comment 2

[:shell escalante]

bug 1346138 as been filed for the icon.  the update behavior is expected.  related issue about a permission change on disabled icon.  need to add to bug about the profile behavior we expect in 57 when a legacy add-on becomes webextension...

Comment 3

[:shell escalante]

krupa is following up with cosmin on exactly what was trying to be caught - seems like a few issues in one bug, confusing

Comment 4

[krupa raj [:krupa--use this to needinfo]]

Here is the updated STR from Cosmin:

 
1.Launch Firefox with clean profile.
2.Open about:config and set the pref extensions.webextPermissionPrompts to true.
3.Open about:config and create the pref xpinstall.signatures.dev-root and set it to true.
4.Open about:config and change the extensions.update.url to point to dev server.
5.Close the browser.
6.Install via sideloading method the version 1.0 from:
  https://addons-dev.allizom.org/en-US/firefox/addon/ubuntunoprompt/versions/
  https://addons-dev.allizom.org/en-US/firefox/addon/ubuntunopermissions/versions/
  https://addons-dev.allizom.org/en-US/firefox/addon/addonversion3/versions/
7.Open the browser.
8.Check for Updates.
9.After the updates, enable the WebExtension from the hamburger menu.
 
WebExtension version 1.0 to WebExtension version 1.1
- After you enable the WebExtension 1.0 from the hamburger menu, the WebExtension 1.1 remains disabled in about:addons while WebExtensions 1.0 is enabled in the toolbar (top right).
- Video: https://www.dropbox.com/s/btvbi7hu3qmsnuo/Extensions.gif?dl=0
 
Add-on version 1.0 to WebExtension version 1.1
- After you enable the Add-on 1.0 from the hamburger menu, the WebExtension 1.1 remains disabled in about:addons while Add-on 1.0 is not present in the toolbar.
- After you enable WebExtension 1.1 from about:addons, the icon is not displayed in the toolbar (top right), it will be visible only if you restart or reopen the web page.
- Video: https://www.dropbox.com/s/0cles62zqcmtjlz/Add-on.gif?dl=0

Comment 5

[Andy McKay]

I think this won't get fixed until we rewrite about:addons. Valid bug but we are just stuck with our legacy code here.