Closed Bug 1347619 Opened 8 years ago Closed 8 years ago

Use calc(50% - 1px) instead of 49.5% in boxmodel.css

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: ntim, Assigned: lockhart)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

No longer blocks: 940275
Component: Developer Tools → Developer Tools: Inspector
Depends on: 1150496
Priority: -- → P3
Could you please be more specific in this bug title? Where is this needed, why? Thanks!
Flags: needinfo?(ntim.bugs)
See https://hg.mozilla.org/integration/mozilla-inbound/rev/9ed72c2f16d8#l4.176 We seem to use 49.5%, because we want to center the label taking in account the line, so calc(50% - 1px) or calc(50% - 0.5px) would be more accurate.
Flags: needinfo?(ntim.bugs)
Summary: Use calc(50% - 1px) instead of 49.5% → Use calc(50% - 1px) instead of 49.5% in boxmodel.css
Assignee: nobody → lockhart
Comment on attachment 8848259 [details] Bug 1347619 - Change boxmodel.css to use calc(50% - 1px) instead of 49.5%. https://reviewboard.mozilla.org/r/121198/#review123210
Attachment #8848259 - Flags: review?(gl) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b66398167216 Change boxmodel.css to use calc(50% - 1px) instead of 49.5%. r=gl
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: