1347820 - Label ScrollSelectionIntoViewEvent for nsSelection

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Jeremy Chen ([e-mail])]

Comparing with other labeling works for layout/generic/ folder, this is relatively trivial. Let's move this as a separate bug, so we can keep moving forward.

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.

Since GetParentObject has a chance returning nullptr, we keep the original
code path as a fallback.

Review commit: https://reviewboard.mozilla.org/r/120892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120892/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8847957 [details]
Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.

https://reviewboard.mozilla.org/r/120892/#review122844

::: layout/generic/nsSelection.cpp:6189
(Diff revision 1)
>  
>    RefPtr<ScrollSelectionIntoViewEvent> ev =
> -      new ScrollSelectionIntoViewEvent(this, aRegion, aVertical, aHorizontal,
> +    new ScrollSelectionIntoViewEvent(this, aRegion, aVertical, aHorizontal,
> -                                       aFlags);
> +                                     aFlags);
> -  nsresult rv = NS_DispatchToCurrentThread(ev);
> +  nsresult rv;
> +  nsIDocument* doc = this->GetParentObject();

No need for "this->".

Comment 3

[Jeremy Chen ([e-mail])]

Comment on attachment 8847957 [details]
Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.

https://reviewboard.mozilla.org/r/120892/#review122844

> No need for "this->".

Yep, I'll fix it.
Thank you for the review. :)

Comment 4

[Jeremy Chen ([e-mail])]

Comment on attachment 8847957 [details]
Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/120892/diff/1-2/

Comment 5

[Jeremy Chen ([e-mail])]

Comment on attachment 8847957 [details]
Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/120892/diff/2-3/

Comment 6

[Jeremy Chen ([e-mail])]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c13b2f647fe3e8afe664a4a20c5851358fcb3b5

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9689473edba
Label ScrollSelectionIntoViewEvent for nsSelection. r=heycam

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9689473edba