Label ScrollSelectionIntoViewEvent for nsSelection

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jeremychen, Assigned: jeremychen)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Comparing with other labeling works for layout/generic/ folder, this is relatively trivial. Let's move this as a separate bug, so we can keep moving forward.
Comment hidden (mozreview-request)
Attachment #8847957 - Flags: review?(cam)
Comment on attachment 8847957 [details]
Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.

https://reviewboard.mozilla.org/r/120892/#review122844

::: layout/generic/nsSelection.cpp:6189
(Diff revision 1)
>  
>    RefPtr<ScrollSelectionIntoViewEvent> ev =
> -      new ScrollSelectionIntoViewEvent(this, aRegion, aVertical, aHorizontal,
> +    new ScrollSelectionIntoViewEvent(this, aRegion, aVertical, aHorizontal,
> -                                       aFlags);
> +                                     aFlags);
> -  nsresult rv = NS_DispatchToCurrentThread(ev);
> +  nsresult rv;
> +  nsIDocument* doc = this->GetParentObject();

No need for "this->".
Attachment #8847957 - Flags: review?(cam) → review+
(Assignee)

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8847957 [details]
Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.

https://reviewboard.mozilla.org/r/120892/#review122844

> No need for "this->".

Yep, I'll fix it.
Thank you for the review. :)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

2 years ago
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9689473edba
Label ScrollSelectionIntoViewEvent for nsSelection. r=heycam

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c9689473edba
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1348222
Depends on: 1348115
You need to log in before you can comment on or make changes to this bug.