Closed
Bug 1347928
Opened 7 years ago
Closed 7 years ago
Remove legacy information-*.png icons
Categories
(Toolkit :: Themes, enhancement)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
I'm going to attach a patch that uses chrome://global/skin/icons/info.svg and chrome://browser/skin/info.svg where appropriate and removes unused information-*.png files. Some of them were already unused without my changes. This will only leave behind information-16.png on Windows.
Comment 1•7 years ago
|
||
The currently unused information-* files are: chrome://global/skin/icons/information-32.png unused on linux chrome://global/skin/icons/information-large.png unused on mac
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8848083 [details] Bug 1347928 - Remove legacy information-*.png icons. https://reviewboard.mozilla.org/r/121060/#review123924 ::: toolkit/themes/osx/global/global.css:77 (Diff revision 1) > > .message-icon { > - list-style-image: url("chrome://global/skin/icons/information-64.png"); > + list-style-image: url("chrome://global/skin/icons/info.svg"); > } > > .alert-dialog #info\.icon, Can you file a good-first-bug to rename these #info.* IDs to #info-* ? It looks like they were introduced by bug 213228, http://searchfox.org/mozilla-central/diff/08a739f6d183178861de18a8619a1fa15f17628b/toolkit/content/commonDialog.xul#25
Attachment #8848083 -
Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9839e96fe10 Remove legacy information-*.png icons. r=jaws
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3) > Can you file a good-first-bug to rename these #info.* IDs to #info-* ? This seems like a nonstarter since this stuff is used by add-ons.
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d9839e96fe10
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•