213228 - new toolkit independence bug

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Pierre Chanial]

Currently, toolkit.jar is built in xpfe/global and a second pass in
mozilla/toolkit overwrites and adds the new files.
We end up with unnecessary files and a duplication of the widgets in particular.
Since more and more apps are using the new toolkit, we need to stabilize a set
of files that we need and reject those we don't.

Comment 1

[Pierre Chanial]

Attachment: plan

Here is the list of the files in xpfe/global (locales are not included for
clarity) their status (already copied, don't copy it, should copy it) and where
to put them in the new toolkit.

Columns:
1: file in xpfe/global
2: proposed place in mozilla/toolkit (if nothing: no change)
3: where the candidates to obsolescence are used (except in xpfe). |mail?|
means that the file is included in mail-jar.mn but doesn't seem to be used.

Symbols:
+ : copy in mozilla/toolkit
- : don't copy
# : already copied

I propose to create a transitional toolkit/obsolete directory where we could
put the files that we won't ship for 1.0. I volunteer to do the job to
eradicate them in the stand alone apps after having an independent toolkit.
Candidates are the following:
- nsClipBoard.js
- nsJSComponentManager.js
- nsJSSupportsUtils.js
- nsTreeController.js
- nsTreeSorting.js
- nsUserSettings.js
- strres.js
- wizardHandlerSet.js, wizardOverlay.*, wizardManager.js: are they really
superceded by wizard.xml?


Also, I think that a components/printing and maybe components/config directory
would make things clearer (not that I like the config stuff).

We should not keep two versions of widgetStateManager. But I don't know what
are the related issues.

Feedback from everybody is welcome.

Comment 2

[Pierre Chanial]

Attachment: plan

updating plan:
- NPL-1.1.html is no more needed since AOL has agreed to convert NPL to MPL
- do copy mozilla.xhtml (my bad, not intentional)

Comment 3

[Mike Potter]

Mostafa Hosseini is the calendar project lead now. (His email is
[e-mail] )

Comment 4

[Pierre Chanial]

Attachment: updated plan

update: 
- obsolete dialogOverlay.xul
- don't copy hiddenWindow.xul
- rename directory: toolkit/components/viewconfig
- style config.css

Comment 5

[Benjamin Smedberg]

Also see bug 211849: toolkit.jar should be application-independant, but there
are TBird-specific #ifdefs in the code.

Comment 6

[Stephen Walker]

commonDialog.dtd needs to be forked to unhork the commonDialog

Comment 7

[Blake Ross]

The nsWidgetStateManager.js fix that was ported was not ported correctly.  Our
nsWidgetStateManager.js had been changed from this.contentArea to gCurrentWindow
for a reason--because we use preference subdialogs.  As a result, subdialogs
like Fonts & Colors are now broken.  Please fix this.

Comment 8

[Blake Ross]

Also, I notice now that if you open a new tab, switch to another tab and then
switch back to the new tab, the urlbar displays 'about:blank'.  This is a
regression--the urlbar used to just clear out.  I suspect this was a bug in the
trunk's tabbrowser.xml...can you look into it?

Comment 9

[Simon Paquet [:sipaq]]

Blake, that's bug 216511. The corresponding bugs in the seamonkey trunk are bug
103720 and bug 104778. Both are fixed.

Comment 10

[Pierre Chanial]

For now, this bug is fixed for Phoenix, we will wait thunderbird next release to
turn off building of xpfe/global for XUL_APP. Therefore, I will leave this bug
open for the time being. Please, go on reporting regressions.

We may have had a 2.2% reduction in redwood Ts, but that's not clear, since this
reduction is preceeded by an abnormal spike.
For sure, we had a reduction of nearly 420K of the toolkit.jar file:
    08-12    08-17
1,284,108  855,090
(linux one)

There are bugs (out of 50-60) that I intentionally did not port because they may
be controversial, or because I had no time to evaluate them. 
Here is the exhaustive list of the bugs not patched in toolkit/content,
toolkit/skin and toolkit/locale:
bug 164006: wyciwyg: should not appear in tab title (phoenix bug 169826)
bug 104778: remember what user typed when switching tabs.
bug 103720: prefill URI when opening new tab.
bug 169589: [mac] ctrl-tab no longer moves btwn frames
bug 203960: go back group
Bug 127589: when switching tabs with find dialog open, update dialog's internal
state so it's "attached" to the focused tab
bug 188956: Clean up Cache pref panel.

Concerning the about:blank regression blake is referring to, note that a worse
regression was occurring before my checkins (bug 215877).
Unfortunately, I won't have time to fix it before my removal to Washington DC
(31st of august). It should be done while carefully porting the bugs mentionned
above.

my toolkit to do list (sometimes in september, but feel free to help):
- help mscott in turning off building of xpfe/global
- fix above bugs and bug 188956
- update toolkit/components
- clean up classicBindings.xml (defunct), globalBindings.xml, xbl rules in
global.css. The PP can help.
- remove contentView and builderView from the whole code (not used in Phoenix
:-) ) see bug 202391 and bug 202393.

Comment 11

[Henrik Gemal]

it seems that due to this bug I'm no longer ableto determine the build of an
installed mozilla firebird from command line.

I used to use the "content\global\build.dtd" file inside toolkit.jar but that
seems gone.

Am I missing something?

I've filed bug 217217 on the missing build.dtd file

Comment 12

[Pierre Chanial]

moving the remaining stuff to 0.8

Comment 13

[Simon Paquet [:sipaq]]

taking over qa abandoned bugs.

Comment 14

[Iain Arnell]

(In reply to comment #2)
> - NPL-1.1.html is no more needed since AOL has agreed to convert NPL to MPL

Pulling NPL-1.1.html has broken the link to the license in the MozillaFirebird
and Firefox about: page.  Since a *lot* of code is still referencing NPL (and
not MPL), it should be restored.

Comment 15

[Simon Paquet [:sipaq]]

This has long been fixed. Toolkit no longer builds on top of XPFE.