Closed Bug 1348041 Opened 3 years ago Closed 3 years ago
Change default of network
.http .max-urgent-start-excessive-connections-per-host to 3
To mitigate bug 1345845 let's lower the number of excessive urgent start connections. Amy, can you do it please? I missed during the last review that you didn't change the value to 4 as I wanted. And when we are here, I think 3 connections will do. Thanks.
Hi Honza, Sorry I didn't change the default of max-urgent-start-excessive-connections-per-host, and I finished to modify it on the patch: 1. Modified the default of network.http.max-urgent-start-excessive-connections-per-host to 3 on all.js 2. Modified the defalut of mMaxUrgntStartQ to 3 on constructor nsHttpHandler(). Would you help me to review my patch? Thanks!
Amy, I have one more thing. The members and some argument should also be renamed from MaxUrgentQ to something more reflecting the new meaning of the preference. Like MaxUrgentExcessiveConns or something. Would you please do it as part of this patch too?
Hi Honza, I have replaced all MaxUrgent to MaxUrgentExcessiveConns. Would you help me to review my patch? Thanks!
Comment on attachment 8849434 [details] [diff] [review] implementation Review of attachment 8849434 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8849434 - Flags: review?(honzab.moz) → review+
Amy, any reason not to land this now?
Hi Honza, Sorry for I was waiting for the testing result of try server. Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f60693a7da7134b87d4f425989ba6819404f56b&selectedJob=86642360
Aha, no problem :)
patching file netwerk/protocol/http/nsHttpConnectionMgr.cpp Hunk #3 FAILED at 1031 1 out of 4 hunks FAILED -- saving rejects to file netwerk/protocol/http/nsHttpConnectionMgr.cpp.rej I'm guessing it was changes on inbound that only recently got merged around?
Already rebased the latest changes on nsHttpConnectionMgr.cpp.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b8a8765f0474 Change default value of network.http.max-urgent-start-excessive-connections-per-host to 3. r=mayhemer
You need to log in before you can comment on or make changes to this bug.