Implement new plugin option for Flash as a checkbox to toggle the allow/blocklist feature (plugins.flashBlock.enabled)

VERIFIED FIXED in Firefox 55

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
3 months ago
9 days ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [fce-active])

User Story

The new Flash allow/blocklists feature will apply to either the "Always Activate" setting (where it will work as a blocklist only) and to the "Ask to Activate" setting (where it _might_ have an allowlist in addition to the blocklist. This is TBD through the study).

The resulting UI is that the dropdown selector for the Activate mode remains unchanged, and a new checkbox is added to the detailed preferences page of the plugin, where the lists feature can be toggled on and off.

The "More" link already takes to that page, but in tune with the other GMP plugins I exposed the "Preferences" button too.

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

3 months ago
The options displayed for the Flash plugin may need to be changed. These are the options that appear in Add-ons Manager > Plugins.

- The entries in the drop-down may change
- A checkbox may be needed
- A preferences page may be needed.

We don't need the final requirements yet but I'll update the user story when we do.
For the record, we already have a preferences page, but it only has options on win32 where there's a checkbox to disable Flash protected mode. That option is not present on win64 or other platforms.

See https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/pluginPrefs.xul#16 and bug 1133000

Updated

3 months ago
Depends on: 1350381

Updated

3 months ago
Whiteboard: [fce-active]
(Assignee)

Updated

3 months ago
User Story: (updated)
(Assignee)

Comment 2

3 months ago
Created attachment 8852140 [details]
plugins-list.png

Main Plugins list page in the Add-ons Manager, where the Preferences button for Flash is now exposed unconditionally (whereas it was only exposed for win32 due to Flash protected mode.. see comment 1)
(Assignee)

Comment 3

3 months ago
Created attachment 8852141 [details]
new-checkbox.png

The new Checkbox that will control the plugins.flashBlock.enabled pref, saying "Always block dangerous and deceptive Flash content". The final text and the address of the Learn More link are yet TBD.
(Assignee)

Comment 4

3 months ago
Created attachment 8852144 [details]
with-protected-mode.png

How the two checkboxes show up together in win32, where the "Enable Flash Protected Mode" checkbox also shows up.

Note that I added the new one before the existing one, because I think this new option is more important so it should come first.
(Assignee)

Updated

3 months ago
Summary: Implement new plugin options for Flash → Implement new plugin option for Flash as a checkbox to toggle the allow/blocklist feature (plugins.flashBlock.enabled)
(Assignee)

Comment 5

3 months ago
Comment on attachment 8852141 [details]
new-checkbox.png

Bram, can you review this (and the other screenshots here)? We can talk on Vidyo if you want. My two goals here are:

- make a final call on the string
- sign off on this UI at least as a first version. If we tweak the UI later we can do as a separate bug, unless this one is a really no-go.
Attachment #8852141 - Flags: ui-review?(bram)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
My proposed version in email was "Block unnecessary or risky Flash content." Other possibilities:

"Speed up Firefox by disabling unnecessary plugin usage."
"Make Firefox safer by disabling unnecessary Flash content."

My goals are to avoid making value judgements about particular domains or content, but to communicate a judgement about whether it represents enhanced risk (advertisers and other widely embedded domains) or whether it's annoying users with Flash prompts for no good reason.
(Assignee)

Comment 9

3 months ago
Ok. And what if we end up using a whitelist too? Is there a version of the string that can transmit the idea that some items will be automatically allowed too?

I was going for something like:

"Let Mozilla automatically allow or block some Flash content to improve my experience", or "to keep me safe", etc..

But I couldn't find a way to further reduce this phrase.
Yeah, I don't have anything better. "Automatically configure Flash for the best experience." is too vague? Need Bram's feedback/advice.
For posterity, I want to add that we've also discussed the potential need for a link to a place to "read more" -- both because of the nature of the changes, but also because as soon as there is talk of how things are determined, or what lists, etc, people are going to want to understand more about this than one line can tell them.

Not sure if that's something we need to incorporate now and plan on launching (via blog post?) in the future or not.
(Assignee)

Comment 12

3 months ago
(In reply to David Durst [:ddurst] from comment #11)
> For posterity, I want to add that we've also discussed the potential need
> for a link to a place to "read more" -- both because of the nature of the
> changes, but also because as soon as there is talk of how things are
> determined, or what lists, etc, people are going to want to understand more
> about this than one line can tell them.
> 
> Not sure if that's something we need to incorporate now and plan on
> launching (via blog post?) in the future or not.

This is already in! See the new-checkbox.png screenshot. Although it's not very clear, the "Learn more" link is related to the checkbox, not to the plugin as a whole.
(Assignee)

Comment 13

3 months ago
Comment on attachment 8852146 [details]
Bug 1348089 - Implement new plugin option for Flash as a checkbox to toggle the allow/blocklist feature (plugins.flashBlock.enabled).

(canceling review for now as we might be adding a new label to provide a better description)
Attachment #8852146 - Flags: review?(rhelmer)

Updated

3 months ago
Flags: needinfo?(mheubusch)

Updated

3 months ago
Blocks: 1351509
I just want to confirm that bug 1351509 is for a later phase, and we still are just seeking one string for the feature launch/landing in 55.

Comment 15

3 months ago
(In reply to David Durst [:ddurst] from comment #14)
> I just want to confirm that bug 1351509 is for a later phase, and we still
> are just seeking one string for the feature launch/landing in 55.

Yes. All that’s left is to finalise the string for 55 (hence needinfo on Michelle). We can think of reorganisation after this bug has been fixed first. That bug shouldn’t impact this one from shipping.
We need to land this soon -- do we have a final string?

Comment 17

2 months ago
(In reply to David Durst [:ddurst] from comment #16)
> We need to land this soon -- do we have a final string?

Hi David: Please use the following string:

Block dangerous and intrusive Flash content
Flags: needinfo?(mheubusch)
Comment hidden (mozreview-request)
(Assignee)

Comment 19

2 months ago
(This update just changed the string.. ReviewBoard decided to re-request review because I moved some patches around my tree, I think..)

Comment 20

2 months ago
mozreview-review
Comment on attachment 8852146 [details]
Bug 1348089 - Implement new plugin option for Flash as a checkbox to toggle the allow/blocklist feature (plugins.flashBlock.enabled).

https://reviewboard.mozilla.org/r/124360/#review126996

Looks like we have some mochitests in
Attachment #8852146 - Flags: review?(rhelmer) → review+
Comment hidden (mozreview-request)

Comment 22

2 months ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bedd46fed76d
Implement new plugin option for Flash as a checkbox to toggle the allow/blocklist feature (plugins.flashBlock.enabled). r=rhelmer

Comment 23

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bedd46fed76d
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1357300
(Assignee)

Updated

2 months ago
No longer depends on: 1357300

Comment 24

17 days ago
Verified as Fixed.
Here are test runs: https://public.etherpad-mozilla.org/p/1348089
Status: RESOLVED → VERIFIED
Updating tracking flags based on Comment 24.
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.