Bug 1317856 (flash-click-to-play)

Make Flash plugin click-to-play (aka "Ask to Activate")

RESOLVED FIXED in Firefox 55

Status

()

Core
Plug-ins
P3
normal
RESOLVED FIXED
6 months ago
4 days ago

People

(Reporter: cpeterson, Assigned: Felipe)

Tracking

(Depends on: 8 bugs, Blocks: 1 bug, 4 keywords)

unspecified
mozilla55
dev-doc-complete, flashplayer, meta, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

6 months ago
In 2017, Firefox will require click-to-activate approval from users before a website activates the Flash plugin for any content:

https://blog.mozilla.org/futurereleases/2016/07/20/reducing-adobe-flash-usage-in-firefox/
(Reporter)

Updated

6 months ago
Depends on: 1274659
(Reporter)

Comment 1

6 months ago
mbest recommends that we ship SharedArrayBuffer (bug 1225406), WebAssembly (bug 1188259), and WebGL2 (bug 889977) before making Flash click-to-play.
Depends on: 889977, 1188259, 1225406

Updated

6 months ago
Keywords: dev-doc-needed, site-compat
(Reporter)

Updated

6 months ago
Depends on: 1277066
No longer depends on: 1312091
No longer depends on: 1295984
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/flash-content-will-be-click-to-activate-in-2017/
(Assignee)

Updated

4 months ago
Depends on: 1335232
(Assignee)

Updated

2 months ago
Depends on: 1348089

Comment 3

2 months ago
(In reply to Chris Peterson [:cpeterson] from comment #1)
> mbest recommends that we ship SharedArrayBuffer (bug 1225406), WebAssembly
> (bug 1188259), and WebGL2 (bug 889977) before making Flash click-to-play.

Why so? Making Flash click-to-play and shipping a bunch of features doesn't seem related.
(Reporter)

Comment 4

2 months ago
(In reply to David Bruant from comment #3)
> (In reply to Chris Peterson [:cpeterson] from comment #1)
> > mbest recommends that we ship SharedArrayBuffer (bug 1225406), WebAssembly
> > (bug 1188259), and WebGL2 (bug 889977) before making Flash click-to-play.
> 
> Why so? Making Flash click-to-play and shipping a bunch of features doesn't
> seem related.

Shipping those other features first means that Flash game developers can launch their WebAssembly/WebGL2 game ports before we make Flash click-to-play. Game developers don't want their users to be interrupted by click-to-play problems. Shipping them first is a nice-to-have, not a strict release blocker.
Depends on: 1351784
(Assignee)

Updated

2 months ago
Depends on: 1352224
(Assignee)

Comment 5

28 days ago
Created attachment 8863032 [details] [diff] [review]
Part 1 - Download and use 3rd-party blocklists

According to the plan, we want to land this now so that users can start downloading these lists in advance for switching Flash as CTA, to give them a better experience.

I'll note that even with Activate-By-Default, this setting will start applying the 3rd-party blocklist for flash.

I'm wrapping this around NIGHTLY_BUILD in order to make it a separate decision/bug to roll this out, and then it will be just a matter of removing the ifdef.
Assignee: nobody → felipc
(Assignee)

Updated

28 days ago
Status: NEW → ASSIGNED
(Assignee)

Updated

28 days ago
Attachment #8863032 - Flags: review?(benjamin)
Attachment #8863032 - Flags: review?(benjamin) → review+

Comment 6

25 days ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddf532ded6f2
Configure Nightly to download and use the flash 3rd party blocklist, in preparation for switching Flash as Click-to-Activate. r=bsmedberg
Backed out for various plugin related test failures, e.g. test_refresh_navigator_plugins.html:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9be2eb8c9061cdfc16d7d53e8f384afa5e1dcb8e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ddf532ded6f21595fe1b88b02cb964994d2d30e2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Flags: needinfo?(felipc)
(Assignee)

Updated

24 days ago
Depends on: 1361433
(Assignee)

Comment 8

24 days ago
The test failures were due to the testing running in a system principal, where plugins will be blocked with this change. I had filed bug 1361433 to change it, but that is intentional, so I cherry-picked the test fixes from bug 1335475 and sent that to tryserver to see if everything will work:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b001dee46c942ccde9efd5a9ca0db5f18fbf561e
Flags: needinfo?(felipc)
(Assignee)

Comment 9

23 days ago
I spun off the pre-req of toggling plugins.flashBlock.enabled to a separate bug
Depends on: 1361798
(Assignee)

Updated

22 days ago
Depends on: 1362149
(Assignee)

Comment 10

17 days ago
Created attachment 8866060 [details] [diff] [review]
Make Flash CTP for Nightly, and favor html5 video content

(This has been through tryserver already and everything passed)
Attachment #8866060 - Flags: review?(benjamin)
Depends on: 1363713
Comment on attachment 8866060 [details] [diff] [review]
Make Flash CTP for Nightly, and favor html5 video content

Please also reset plugins.navigator.hidden_ctp_plugin to "" on all channels. https://dxr.mozilla.org/mozilla-central/rev/d8762cb967423618ff0a488f14745f60964e5c49/modules/libpref/init/all.js#3012

r=me with that addition

Please wait to land this until the week 2 flash list items are in production: so maybe land Monday for Tuesday's nightly?
Attachment #8866060 - Flags: review?(benjamin) → review+
(Assignee)

Comment 12

15 days ago
(In reply to Benjamin Smedberg [:bsmedberg] from comment #11)
> Comment on attachment 8866060 [details] [diff] [review]
> Make Flash CTP for Nightly, and favor html5 video content
> 
> Please also reset plugins.navigator.hidden_ctp_plugin to "" on all channels.
> https://dxr.mozilla.org/mozilla-central/rev/
> d8762cb967423618ff0a488f14745f60964e5c49/modules/libpref/init/all.js#3012

ah, good catch. FWIW the study/experiment did this, I just forgot about it in this patch.

> 
> r=me with that addition
> 
> Please wait to land this until the week 2 flash list items are in
> production: so maybe land Monday for Tuesday's nightly?


Sounds good. I'll try to get a patch to prefer fallback in the SWFObject case too, and hopefully land that before or together with this.
(Assignee)

Updated

14 days ago
Depends on: 1364505
Comment hidden (mozreview-request)

Comment 14

10 days ago
mozreview-review
Comment on attachment 8868255 [details]
Bug 1317856 - Ensure that flashblock tests are not affected by nosrc fallback rule.

https://reviewboard.mozilla.org/r/139838/#review143190

::: toolkit/components/url-classifier/tests/browser/flash_block_frame.html:10
(Diff revision 1)
>  </head>
>  <body>
>    <h1>Test page</h1>
> -  <object id="testObject" width="100" height="100" type="application/x-shockwave-flash-test"></object>
> +  <object id="testObject" width="100" height="100"
> +  		  type="application/x-shockwave-flash-test"
> +  		  data="simple_blank.swf"></object>

nit: tabs should be spaces
Attachment #8868255 - Flags: review?(ksteuber) → review+

Comment 15

10 days ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddc27dd93ec0
Ensure that flashblock tests are not affected by nosrc fallback rule. r=bytesized
https://hg.mozilla.org/integration/mozilla-inbound/rev/12a7b0378709
Make the Flash plugin Click-to-Activate by default on Nightly. r=bsmedberg

Comment 16

9 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ddc27dd93ec0
https://hg.mozilla.org/mozilla-central/rev/12a7b0378709
Status: ASSIGNED → RESOLVED
Last Resolved: 9 days ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Updated

9 days ago
Blocks: 1365714
(Assignee)

Updated

9 days ago
See Also: → bug 1365714
I've documented this, piggy backing it on the Flash http/https-only update as it seemed to fit well:

https://developer.mozilla.org/en-US/docs/Plugins
https://developer.mozilla.org/en-US/Firefox/Releases/55
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.