stylo: Support getting authored property value

NEW
Assigned to

Status

()

Core
CSS Parsing and Computation
P2
normal
2 months ago
a month ago

People

(Reporter: xidorn, Assigned: mbrubeck)

Tracking

(Blocks: 3 bugs)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 months ago
layout/style/test/chrome/test_author_specified_style.html is testing that we get the color value in a way similar to how author specifies it.

This basically means we need to have a real implementation of ServoDeclarationBlock::GetAuthoredPropertyValue rather than simply redirecting it to GetPropertyValue.

Servo stores an authored string if the value is an identifier, but it doesn't do much otherwise. Also Servo doesn't have a mechanism to distinguish between authored serialization and normalized serialization like Gecko.

We may need to add the mechanism to Servo and store some additional information for color there.
(Reporter)

Comment 1

2 months ago
There could be some non-trivial work for this in the Servo side (to implement the mechanism distinguishing authored serialization and normalized serialization). This is mostly for devtools support because they need to show the authored one in the panel.
Blocks: 1322657
Priority: -- → P2
Assignee: nobody → mbrubeck
Priority: P2 → P1
Actually, bug 1349651 is higher priority, so swapping that one out for this one.
Assignee: mbrubeck → nobody
Priority: P1 → P2
Blocks: 1243581
I guess this is the same set of code as bug 1349651 though, so probably makes sense for matt to work on this after that one.
Assignee: nobody → mbrubeck
You need to log in before you can comment on or make changes to this bug.