Closed Bug 1348169 Opened 5 years ago Closed 5 years ago

Fix NaN shown in the Box Model's margins

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox52 unaffected, firefox53 unaffected, firefox54 wontfix, firefox55 verified)

VERIFIED FIXED
Firefox 55
Tracking Status
firefox52 --- unaffected
firefox53 --- unaffected
firefox54 --- wontfix
firefox55 --- verified

People

(Reporter: magicp.jp, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image nan-in-boxmodel.png
Steps to reproduce:
1. Start latest Nightly
2. Go to about:home
3. Open Inspector > Computed
4. Select #downloads:before in markup
5. See Box Model

Actual Results:
"NaN" shown for margin-left/margin-right in the Box Model.

Expected Results:
"auto" should be shown for margin-left/margin-right in the Box Model.

Another step to reproduce:
In step 4, select #searchSuggestionTable. "NaN" shown for position-top/position-right/position-bottom.

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=fcef571d22c3ad151a62cb1cad6d751f79a72446&tochange=fd85a5aafa9fdc2fbe012408e996f573308fb697
Blocks: 1336198
Has Regression Range: --- → yes
Has STR: --- → yes
Blocks: 1150496, 1347964
No longer blocks: 1336198
Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8849108 [details]
Bug 1348169 - Fix NaN shown in the Box Model's margins.

https://reviewboard.mozilla.org/r/121938/#review123940

This looks like the kind of things that would really benefit from a new non-reg test.
We know exactly what makes it fail, it would be very easy to add a new test that prevents it in the future.
Can you add one please?
Attachment #8849108 - Flags: review?(pbrosset)
Summary: Fix NaN shown in the Box Model → Fix NaN shown in the Box Model's margins
Blocks: 1349216
Flags: qe-verify+
Comment on attachment 8849108 [details]
Bug 1348169 - Fix NaN shown in the Box Model's margins.

https://reviewboard.mozilla.org/r/121938/#review126726

Thanks for adding this test. It looks nice.
Attachment #8849108 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48848888a7b3
Fix NaN shown in the Box Model's margins. r=pbro
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efb00df6a299
Fix NaN shown in the Box Model's margins. Fix eslint issues. r=style-fix on a CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/48848888a7b3
https://hg.mozilla.org/mozilla-central/rev/efb00df6a299
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified fixed using the latest Nightly 55.0a1 (2017-03-31) on Ubuntu 16.04, Mac OS X 10.12 and Windows 10 x64. "Auto" appears in the Box Model for margin-left/margin-right.
The latest Developer Edition (20170331004006) is affected. Please uplift to 54.
(In reply to magicp from comment #10)
> The latest Developer Edition (20170331004006) is affected. Please uplift to
> 54.

Gabriel, what do you think about uplift to beta at this point?
Flags: needinfo?(gl)
Comment on attachment 8849108 [details]
Bug 1348169 - Fix NaN shown in the Box Model's margins.

Approval Request Comment
[Feature/Bug causing the regression]: 1336198
[User impact if declined]: NaN shown in the Box Model's margins.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Already verified.
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Covered by unit tests and a simple number parsed error.
[String changes made/needed]: None
Flags: needinfo?(gl)
Attachment #8849108 - Flags: approval-mozilla-beta?
Comment on attachment 8849108 [details]
Bug 1348169 - Fix NaN shown in the Box Model's margins.

We've already built RC build for 54 today and this is too late for 54. Beta54- and mark 54 won't fix.
Attachment #8849108 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
I reproduced this bug mentioned in comment 0 using Nightly 55.0a1 (2017-03-16) (64-bit),Build ID: 20170316110253 on Linux x64.

This Bug is now verified as fixed on Latest Firefox Nightly 55.0a1 (2017-06-06) (64-bit)

Build ID: 20170606100219
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
OS: Linux 4.8.0-53-generic
QA Whiteboard: [bugday-20170607]
I have reproduced this bug with Nightly 55.0a1 (2017-03-16) (64-bit) on Windows 7, 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID   :  20170606030207
User Agent :  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170607]
I have managed to reproduce the issue mentioned in comment 0 using Firefox 55.0a1 (BuildId:20170316030211).

This issue is verified fixed on Firefox 55.0b3 (BuildId:20170619071723) using Windows 10 64bit, Ubuntu 16.04 64bit and macOS 10.11.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.