Closed Bug 1349216 Opened 8 years ago Closed 8 years ago

Fix NaN shown in the Box Model's positions

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox55 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

1349216.patch [2.0]
6.20 KB, patch
pbro
: review+
Details | Diff | Splinter Review
No description provided.
Depends on: 1348169
Summary: Fix Nan shown in the Box Model's positions → Fix NaN shown in the Box Model's positions
Flags: qe-verify+
Attached patch 1349216.patch (obsolete) — — Splinter Review
Attachment #8851082 - Flags: review?(pbrosset)
Attachment #8851082 - Attachment is obsolete: true
Attachment #8851082 - Flags: review?(pbrosset)
Attachment #8851309 - Flags: review?(pbrosset)
Comment on attachment 8851309 [details] [diff] [review] 1349216.patch [2.0] Review of attachment 8851309 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks!
Attachment #8851309 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6f85cbca097 Fix NaN shown in the Box Model's positions. r=pbro
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/9e0883bc652e Fix NaN shown in the Box Model's positions. Fix eslint issues. r=style-fix
https://hg.mozilla.org/mozilla-central/rev/e6f85cbca097 https://hg.mozilla.org/mozilla-central/rev/9e0883bc652e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified fixed using the latest Nightly 55.0a1 (2017-03-31) on Ubuntu 16.04, Mac OS X 10.12 and Windows 10 x64. "Auto" appears in the Box model for position-top/position-right/position-bottom when " #searchSuggestionTable" is selected.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Gabriel I'm flagging this as qe- since it seems very well covered with the unit test. Otherwise can you please provide steps to verify the bug?
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(gl)
Sounds fine.
Flags: needinfo?(gl)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: