stylo: need support for :-moz-window-inactive

RESOLVED FIXED in Firefox 56

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
4 months ago
21 days ago

People

(Reporter: bz, Assigned: mbrubeck)

Tracking

(Blocks: 3 bugs)

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 disabled, firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Priority: -- → P2
Assignee: nobody → emilio+bugs
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1350140
Note that this one in particular is _not_ an EVENT_STATE pseudo-class, so it's not a dupe of bug 1350140. But it's trivial to implement, so I might as well do it right after that bug lands.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Oh I see - I saw it in the list in your patch, but realized that that was the list of "Pending pseudo-classes", which presumably means the unimplemented ones. So I had it backwards. :-)
(Assignee)

Comment 4

28 days ago
I can take this if you like, since it's a natural next step after bug 1367312.
Flags: needinfo?(emilio+bugs)
(Assignee)

Updated

28 days ago
Assignee: emilio+bugs → mbrubeck
Status: REOPENED → ASSIGNED
Flags: needinfo?(emilio+bugs)
(Assignee)

Comment 5

27 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed0eb5f4013afbc29c6369214de972aa66d70d1b
Comment hidden (mozreview-request)

Comment 7

26 days ago
mozreview-review
Comment on attachment 8882159 [details]
Bug 1348489 - stylo: Implement :-moz-window-inactive.

https://reviewboard.mozilla.org/r/153282/#review158446

::: layout/style/ServoBindings.cpp:828
(Diff revision 1)
>  {
>    return aDocument->ThreadSafeGetDocumentLWTheme();
>  }
>  
> +mozilla::EventStates
> +Gecko_GetDocumentState(const nsIDocument *aDocument) {

nit: brace to the next line, star near the type. Also in the function above you (I think I pointed this out too in my review for that).
Attachment #8882159 - Flags: review?(emilio+bugs) → review+

Comment 8

26 days ago
mozreview-review
Comment on attachment 8882159 [details]
Bug 1348489 - stylo: Implement :-moz-window-inactive.

https://reviewboard.mozilla.org/r/153282/#review158450

::: layout/style/ServoBindings.h:169
(Diff revision 1)
>  bool Gecko_MatchLang(RawGeckoElementBorrowed element,
>                       nsIAtom* override_lang, bool has_override_lang,
>                       const char16_t* value);
>  nsIAtom* Gecko_GetXMLLangValue(RawGeckoElementBorrowed element);
>  nsIDocument::DocumentTheme Gecko_GetDocumentLWTheme(const nsIDocument *aDocument);
> +mozilla::EventStates Gecko_GetDocumentState(const nsIDocument *aDocument);

here too, the star with the type.
(Assignee)

Comment 9

26 days ago
https://github.com/servo/servo/pull/17564

Comment 10

26 days ago
Pushed by mbrubeck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5487628d6625
stylo: Implement :-moz-window-inactive. r=emilio
Backed out both gecko and servo part for Windows bustage: no 'object' file generated at mozilla/ServoBindings.h(169) in gecko-side patch:

https://hg.mozilla.org/integration/autoland/rev/7dbb471b3dbc4e5c9ae579faa85d5d5155b052ee
https://hg.mozilla.org/integration/autoland/rev/8ebb8f6003c0b4b5919a0db5f05fa2deebb6f2ec

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5487628d6625b4f52701c9984782be4521d509bd&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=110831350&repo=autoland

12:58:49     INFO -  c:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/sccache2/sccache.exe c:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/vs2015u3/VC/bin/amd64/cl.exe -Food_dering_sse2.obj -c  -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Ic:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/media/libaom -Ic:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/obj-firefox/media/libaom  -Ic:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/obj-firefox/dist/include  -Ic:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/obj-firefox/dist/include/nspr -Ic:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/obj-firefox/dist/include/nss        -MD -FI c:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -deps.deps/od_dering_sse2.obj.pp -utf-8 -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4244 -wd4267 -we4553  -Z7 -O1 -Oi -Oy- -Ic:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/media/libaom/config/win/x64/ -Ic:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/third_party/aom -Ic:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/media/libaom/config   c:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/third_party/aom/av1/common/od_dering_sse2.c
12:58:49     INFO -  Unified_cpp_intl_locale0.cpp
12:58:49     INFO -  c:\builds\moz2_slave\autoland-w64-00000000000000000\build\src\obj-firefox\dist\include\mozilla/ServoBindings.h(169): error C2220: warning treated as error - no 'object' file generated
12:58:49     INFO -  c:\builds\moz2_slave\autoland-w64-00000000000000000\build\src\obj-firefox\dist\include\mozilla/ServoBindings.h(169): warning C4190: 'Gecko_GetDocumentState' has C-linkage specified, but returns UDT 'mozilla::EventStates' which is incompatible with C
12:58:49     INFO -  c:\builds\moz2_slave\autoland-w64-00000000000000000\build\src\obj-firefox\dist\include\nsIDocument.h(110): note: see declaration of 'mozilla::EventStates'
12:58:49     INFO -  c:/builds/moz2_slave/autoland-w64-00000000000000000/build/src/config/rules.mk:1010: recipe for target 'Unified_cpp_intl_locale0.obj' failed
12:58:49     INFO -  mozmake.EXE[5]: *** [Unified_cpp_intl_locale0.obj] Error 2
Flags: needinfo?(mbrubeck)
(Assignee)

Comment 12

25 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=53aaeb950dee61529e81f69991f78e05bfbe2d36
Flags: needinfo?(mbrubeck)
(Assignee)

Comment 13

25 days ago
Fixed the build error on Windows, per emilio's suggestion.

https://github.com/servo/servo/pull/17577

Comment 14

25 days ago
Pushed by mbrubeck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c18f9c43688
stylo: Implement :-moz-window-inactive. r=emilio
https://hg.mozilla.org/mozilla-central/rev/3c18f9c43688
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago24 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
status-firefox55: affected → disabled
You need to log in before you can comment on or make changes to this bug.