1348560 - About page and your rights page in Firefox Focus for Android aren't localizable

Status: RESOLVED WORKSFORME

(Focus-iOS :: General, defect)

Description

[Amir Farsi]

Attachment: YourRightsEngScreenShot

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce:

I'm testing Firefox Focus for Android to be sure if it's working fine with RTL languages?
I'm using Persian language.
I touched About option Your Rights option in settings menu.


Actual results:

I saw an English content in About and Your Rights section. I tried to translate them via pontoon. But there wasn't any untranslated string that is related to About window and Your Rights Window. Pontoon showing Firefox Focus for Android 100 % translated. I attached the screenshot.


Expected results:

It should be localizable and we should be able to translate them to our mother language(such as Persian).

Comment 1

[Amir Farsi]

I wanted to update this Bug report. I saw the texts that are related to About window. These texts are translated to Persian by our team. But I don't know why in Firefox Focus, it's English yet. In addition "About Firefox Focus(Beta)" option in settings menu is in English, although we our team members translated this option before now.

In addition in title of About window it showing translation of Help word instead translation of About word.
For more info about this problem please look at https://bugzilla.mozilla.org/show_bug.cgi?id=1348550 also.

Comment 2

[Amir Farsi]

Attachment: AboutWindowPersianLanguage

I attached the screenshot of About window also.

Comment 3

[Amir Farsi]

Update:
I saw a tag problem in translation of our About page.I fixed it. I think the problem of About page(Window) was because invalid html tags that if fixed them. I'm wait for receiving newer version of Firefox Focus for Android via Buddy Builds to check it again.
 
But the problem of Your Rights page that isn't localizable, is alive. I can't see contents of Your Rights page in pontoon. It seams Your Rights page isn't localizable.

Comment 4

[Amir Farsi]

Hi there.
I recived newer update of focus via BuddyBuilders.
Now My fixing on About page is working correctly. The About page now is in Persian language!

But there is some problems yet:

1-The contents of About page should be Right to Left when it's in is Persian, but it's Left to Right!

Question: As you know, the about page using html tags in it's contents. I want to know i should add the the tags like <dir="rtl"> in the translated scripts or focus developers should solve the Direction problem in About page when focus using a RTL language in it's UI??


2-The problem that was for Your Rights page is available yet. Please solve that problem. Your Rights page isn't translatable, because it's strings are not accessible via pontoon.

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks for filing Amir! :)
1/ That should not require any action on your part. I'll take a look at what current status is on this page (out at a workshop now and don't have access to my iOS device)
2/ Your Rights page is not localizable on purpose for legal reasons (I think we need like a lawyer basically to translate those). We don't localize them for Focus for iOS either, just to give an example.

Thanks for your help!

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #5)
> Thanks for filing Amir! :)
> 1/ That should not require any action on your part. I'll take a look at what
> current status is on this page (out at a workshop now and don't have access
> to my iOS device)

Uhm - I meant android

> 2/ Your Rights page is not localizable on purpose for legal reasons (I think
> we need like a lawyer basically to translate those). We don't localize them
> for Focus for iOS either, just to give an example.
> 
> Thanks for your help!

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: Focus_iOS.PNG

RTL layout is still incorrect here: https://people-mozilla.org/~npark/Focus_Screenshot/fa/images/phoneScreenshots/About_Page_1492720627621.html

Please compare with screenshot attached, which is the correct layout on Focus for iOS 

(note: I know you guys usually file issues on GitHub for Focus on Android, but contributor wasn't aware at the time ;) )

Comment 8

[Delphine Lebédel [:delphine - Use needinfo]]

St3fan: should I file this under GitHub or is it ok here?

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

This is now localizable. Closing.