1348802 - stylo: Servo implements selectors-4's :not, Gecko implements selectors-3

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

In particular, Servo's :not selectors can contain combinators, unlike Gecko's.

See https://github.com/servo/servo/pull/15890.

We should decide what to do about this.

Comment 1

[Bobby Holley (:bholley)]

We should downgrade to level 3 and then reconsider after stylo ships. I have a patch.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Downgrade selectors not() behavior to level 3. v1

MozReview-Commit-ID: 6p750Ml2wzm

Comment 3

[Simon Sapin (:SimonSapin)]

Comment on attachment 8861292 [details] [diff] [review]
Downgrade selectors not() behavior to level 3. v1

Review of attachment 8861292 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

I also checked :moz-any parsing, it seems to be equivalent:

https://github.com/servo/servo/blob/f3c1bbe0700806ef2def3b0c5ce0dde4eba107ea/components/style/gecko/selector_parser.rs#L400-L409
http://searchfox.org/mozilla-central/rev/baf47b352e873d4516d7656186d6d7c7447d3873/layout/style/nsCSSParser.cpp#6502

Comment 4

[Bobby Holley (:bholley)]

https://github.com/servo/servo/pull/16606

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b90e552d82d
Update test expectations. r=me

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b90e552d82d