1348954 - Html5-video controls do not hide when in fullscreen

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Franck (Wip)]

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Reproducible with Nightly 55 64bits on Windows 7.

Steps to reproduce:
 - open a simple "<video> tagged" video
   e.g. https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html 
 - start the video playing
 - switch to fullscreen (double-click on the container or use the dedicated button)
 - move the mouse to ensure that the controls are displayed

Actual results:
 video controls do not hide whatever the time you wait

Expected results:
 video controls should hide themselves after a short delay

By the way, the mouse cursor does not hide either.
Should I file another bug for that ?

Comment 1

[Franck (Wip)]

Attachment: Browser Console errors

There are errors in the Browser Console that I think are related in "videocontrols.xml" :

 - videocontrols.xml:1107:11 "TypeError: this.Utils is undefined"
   >>  this.Utils._controlsHiddenByTimeout = false;

 - videocontrols.xml:1271:45 "TypeError: this.Utils is undefined"
   >>  this.Utils._hideControlsTimeout = setTimeout(this._hideControlsFn, this.HIDE_CONTROLS_TIMEOUT_MS);

 - videocontrols.xml:1019:13 "TypeError: this.Utils is undefined"
   >> _hideControlsFn() { if (!this.Utils.scrubber.isDragging) { [...]

Comment 2

[Franck (Wip)]

Forgot to mention :
 - build ID : 20170320030209
 - tested with a new/clean profile

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]: Video control UI is broken since 54

Comment 4

[Blake Wu [:bwu][:blakewu]]

Ni Tim :-)

Comment 5

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=541cb234a772d4cf62379538530b9534e1d141cc&tochange=6055065a2ed5bbfa0dafb62d13d62e33e2742eab

Regressed by: Bug 1341029

Comment 6

[Mark Banner (:standard8)]

Bah, I must admit I wasn't 100% sure about those changes, but I couldn't see any negative effects.

I'll try and fix this in the next day or so.

Comment 7

[Ray Lin[:ralin]]

I think the problem is that we bind the "Utils" context to all event listeners[0], so we can not access "Utils" property of "Utils" itself. To have a quick fix for this problem, we could revert the change[1] and explicitly comment /* global Utils */ in <constructor>, though it might be a misuse of eslint....

[0] https://dxr.mozilla.org/mozilla-central/rev/05bfa2831c0ba4a26fa72328ffe6a99aba9c356a/toolkit/content/widgets/videocontrols.xml#1839-1847
[1] https://hg.mozilla.org/integration/autoland/diff/6055065a2ed5/toolkit/content/widgets/videocontrols.xml

Comment 8

[Mark Banner (:standard8)]

Thank you Franck for finding this.

Having looked at it a bit more, I'm in agreement with Ray. There's possibly some better method, however, it won't pollute what ESLint knows about the global space for other methods, so I think it is safe to go with for this case.

Comment 9

[Mark Banner (:standard8)]

Attachment: Bug 1348954 - Html5-video controls do not hide when in fullscreen.

Undo incorrect change from bug 1341029, and tell ESLint about how Utils is 'global' to some of the videocontrols.xml event listeners.

Review commit: https://reviewboard.mozilla.org/r/122374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122374/

Comment 10

[Ray Lin[:ralin]]

Comment on attachment 8849590 [details]
Bug 1348954 - Html5-video controls do not hide when in fullscreen.

https://reviewboard.mozilla.org/r/122374/#review124766

LGTM, thanks :D

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca09d56a65e4
Html5-video controls do not hide when in fullscreen. r=ralin

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 8849590 [details]
Bug 1348954 - Html5-video controls do not hide when in fullscreen.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1341029
[User impact if declined]: Video controls can't be hidden.
[Is this code covered by automated tests?]: Not currently (as it wouldn't have regressed).
[Has the fix been verified in Nightly?]: Just landed.
[Needs manual test from QE? If yes, steps to reproduce]: Yes, see STR in comment 0.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It backs out the changes made from the regressing bug (fixes the eslint issue via an alternative route).
[String changes made/needed]: None

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca09d56a65e4

Comment 15

[Gerry Chang [:gchang]]

Track 54+ as regression.

Comment 16

[Gerry Chang [:gchang]]

Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!

Comment 17

[Franck (Wip)]

Confirmed fixed in the latest Nightly (Build ID 20170323030203, Win7-x64)
Thanks.

The mouse still do not hide though.
I will file another bug...

Comment 18

[Gerry Chang [:gchang]]

Comment on attachment 8849590 [details]
Bug 1348954 - Html5-video controls do not hide when in fullscreen.

Fix a UI issue related to video controls in fullscreen and was verified. Aurora54+.

Comment 19

[Hani Yacoub, Desktop QA]

Build ID: 20170326030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64 that the video controls hide after few seconds when full screen.

I would like to mention that the mouse cursor does not hide and there is a bug logged bug 1350315.

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55ed104c9039

Comment 21

[Emil Ghitta, QA [:emilghitta]]

I’ve reproduced the issue described in comment 0 using Firefox 55.0a1 (Build Id:20170320030209) and verified that the issue is not reproducible anymore using Firefox 54.0b1 (Build Id:20170420011827) on Windows 64bit.