Closed Bug 1349002 Opened 8 years ago Closed 8 years ago

Build DMD with unified sources

Categories

(Core :: DMD, enhancement)

Product:
Core
Component:
DMD
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

Build DMD with unified sources
1.23 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review
DMD can be built with unified sources, additionally it doesn't need NSPR's strcpy to build properly. MozReview-Commit-ID: 9hZFlpWdt7
Attachment #8849311 - Flags: review?(n.nethercote)
Comment on attachment 8849311 [details] [diff] [review] Build DMD with unified sources Review of attachment 8849311 [details] [diff] [review]: ----------------------------------------------------------------- r=me if it builds! The strcpy.c seems to go all the way back to bug 717853 comment 59. Seems like it was necessary for B2G.
Attachment #8849311 - Flags: review?(n.nethercote) → review+
We were #including <pthread.h> inside our namespace in DMD.cpp which caused issues when compiling in unified mode on mac.
Flags: needinfo?(erahm)
https://hg.mozilla.org/mozilla-central/rev/0c3915509f06
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: