1349145 - Revert the code of bug 1203047

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per bug 1318225 comment 6, we want to revert the changes since the abstraction is no longer needed.

This will also remove unnecessary checks and casting.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1349145. P1 - revert the changes in bug 1203047 for MediaDecoderReader and its friends.

Review commit: https://reviewboard.mozilla.org/r/122594/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122594/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1349145. P2 - revert the changes in bug 1203047 for MediaBufferDecoder.cpp.

Review commit: https://reviewboard.mozilla.org/r/122596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122596/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1349145. P3 - use concrete types in MDSM and its friends. Also remove unnecessary casts.

Review commit: https://reviewboard.mozilla.org/r/122598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122598/

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8849864 [details]
Bug 1349145. P3 - use concrete types in MDSM and its friends. Also remove unnecessary casts.

https://reviewboard.mozilla.org/r/122598/#review124798

::: dom/media/MediaDecoderStateMachine.cpp:1383
(Diff revision 1)
>      return NS_OK;
>    }
>  
> -  nsresult DropVideoUpToSeekTarget(MediaData* aSample)
> +  nsresult DropVideoUpToSeekTarget(VideoData* aSample)
>    {
> -    RefPtr<VideoData> video(aSample->As<VideoData>());
> +    RefPtr<VideoData> video(aSample);

We can save this AddRef().

::: dom/media/mediasink/AudioSink.h:17
(Diff revision 1)
>  
>  #include "MediaSink.h"
>  
>  namespace mozilla {
>  
>  class MediaData;

We can remove this line now.

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8849862 [details]
Bug 1349145. P1 - revert the changes in bug 1203047 for MediaDecoderReader and its friends.

https://reviewboard.mozilla.org/r/122594/#review124818

::: commit-message-8c32a:2
(Diff revision 1)
> +Bug 1349145. P1 - revert MediaDecoderReader and its friends. r?jya
> +

Please state what it is you sre reverting in the commit log and put either the bug numbrr being or commit being reverted  

as it is, one looking at this change can't tell what it is about...

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8849862 [details]
Bug 1349145. P1 - revert the changes in bug 1203047 for MediaDecoderReader and its friends.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122594/diff/1-2/

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8849863 [details]
Bug 1349145. P2 - revert the changes in bug 1203047 for MediaBufferDecoder.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122596/diff/1-2/

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8849864 [details]
Bug 1349145. P3 - use concrete types in MDSM and its friends. Also remove unnecessary casts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122598/diff/1-2/

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8849863 [details]
Bug 1349145. P2 - revert the changes in bug 1203047 for MediaBufferDecoder.cpp.

https://reviewboard.mozilla.org/r/122596/#review124944

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the reviews!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d37892e8bc4b
P1 - revert the changes in bug 1203047 for MediaDecoderReader and its friends. r=jya
https://hg.mozilla.org/integration/autoland/rev/1488b925092f
P2 - revert the changes in bug 1203047 for MediaBufferDecoder.cpp. r=jya
https://hg.mozilla.org/integration/autoland/rev/1f50634b7a51
P3 - use concrete types in MDSM and its friends. Also remove unnecessary casts. r=kaku

Comment 12

[Carsten Book [:Tomcat]]

landed on m-c
https://hg.mozilla.org/mozilla-central/rev/d37892e8bc4b
https://hg.mozilla.org/mozilla-central/rev/1488b925092f

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f50634b7a51